Page MenuHomePhabricator
Differential D4292

[Nix] Update nix flake lock, fix arcanist
ClosedPublic
Actions

Authored by • jon on Jun 19 2022, 11:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 9:35 PM
Unknown Object (File)
Thu, Mar 13, 11:29 AM
Unknown Object (File)
Thu, Mar 13, 11:29 AM
Unknown Object (File)
Thu, Mar 13, 11:29 AM
Unknown Object (File)
Thu, Mar 13, 11:28 AM
Unknown Object (File)
Thu, Mar 13, 11:22 AM
Unknown Object (File)
Wed, Mar 12, 1:35 PM
Unknown Object (File)
Wed, Mar 5, 5:38 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek
varun

Details

Reviewers
varun
ashoat
Commits
rCOMM05854b131c4c: [Nix] Update nix flake lock, fix arcanist
Summary

Fixes arcanist, avoid using php8.1 as it's current unsupported

Depends on D4181

Test Plan

nix develop && arc diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jun 19 2022, 11:15 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 19 2022, 11:15 AM
• jon added a child revision: D4293: [services] Bump libuv compatibility.Jun 19 2022, 11:17 AM
Harbormaster completed remote builds in B9802: Diff 13566.Jun 19 2022, 11:20 AM
• jon requested review of this revision.Jun 19 2022, 11:20 AM
• jon retitled this revision from Update nix flake lock to [Nix] Update nix flake lock.Jun 19 2022, 11:30 AM
• jon edited the summary of this revision. (Show Details)
• jon retitled this revision from [Nix] Update nix flake lock to [Nix] Update nix flake lock, fix arcanist.Jun 20 2022, 5:05 PM
varun accepted this revision.Jun 21 2022, 11:30 AM
This revision is now accepted and ready to land.Jun 21 2022, 11:30 AM
Herald added a reviewer: ashoat. · View Herald TranscriptJun 21 2022, 11:30 AM
This revision now requires review to proceed.Jun 21 2022, 11:30 AM
varun added inline comments.Jun 21 2022, 11:51 AM
nix/overlay.nix
25

nit: PHP 8.1

25

nvm, actually, i see it styled as php8.1 too

ashoat added inline comments.Jun 22 2022, 10:17 AM
nix/overlay.nix
25

Please keep all lines to a maximum of 80 chars!! (Exceptions for quirky languages such as Objective-C and bash)

ashoat accepted this revision.Jun 22 2022, 10:17 AM
This revision is now accepted and ready to land.Jun 22 2022, 10:17 AM
• jon updated this revision to Diff 13697.Jun 22 2022, 7:53 PM
• jon marked 3 inline comments as done.

Line length

• jon added a comment.Jun 22 2022, 7:53 PM

Addressed comments :)

Harbormaster completed remote builds in B9905: Diff 13697.Jun 22 2022, 8:33 PM
Closed by commit rCOMM05854b131c4c: [Nix] Update nix flake lock, fix arcanist (authored by • jon). · Explain WhyJun 22 2022, 9:25 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM05854b131c4c: [Nix] Update nix flake lock, fix arcanist.

Revision Contents
Changeset List

PathSize
6 lines
nix/
5 lines

Diff 13566

View Options

flake.lock

Show All 36 Lines const {
threadInfo, threadInfo,
setErrorMessage, setErrorMessage,
} = props; } = props;
const modalContext = useModalContext(); const modalContext = useModalContext();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callDeleteThread = useServerCall(deleteThread); const callDeleteThread = useServerCall(deleteThread);
const accountPasswordInputRef = React.useRef();
const deleteThreadAction = React.useCallback(async () => { const deleteThreadAction = React.useCallback(async () => {
try { try {
const response = await callDeleteThread(threadInfo.id, accountPassword); const response = await callDeleteThread(threadInfo.id, accountPassword);
modalContext.clearModal(); modalContext.clearModal();
return response; return response;
} catch (e) { } catch (e) {
setErrorMessage( setErrorMessage(
e.message === 'invalid_credentials' ? 'wrong password' : 'unkown error', e.message === 'invalid_credentials' ? 'wrong password' : 'unkown error',
); );
setAccountPassword(''); setAccountPassword('');
// TODO: accountPasswordInput.focus() accountPasswordInputRef.current?.focus();
// (once ref is moved up to functional component)
throw e; throw e;
} }
}, [ }, [
accountPassword, accountPassword,
callDeleteThread, callDeleteThread,
modalContext, modalContext,
setAccountPassword, setAccountPassword,
setErrorMessage, setErrorMessage,
Show All 23 Lines <>
<div className={css.form_title}>Account password</div> <div className={css.form_title}>Account password</div>
<div className={css.form_content}> <div className={css.form_content}>
<input <input
type="password" type="password"
placeholder="Personal account password" placeholder="Personal account password"
value={accountPassword} value={accountPassword}
onChange={onChangeAccountPassword} onChange={onChangeAccountPassword}
disabled={inputDisabled} disabled={inputDisabled}
ref={accountPasswordInputRef}
/> />
</div> </div>
</div> </div>
<Button onClick={onDelete} variant="danger" disabled={inputDisabled}> <Button onClick={onDelete} variant="danger" disabled={inputDisabled}>
Delete Delete
</Button> </Button>
</> </>
); );
} }
export default ThreadSettingsDeleteTab; export default ThreadSettingsDeleteTab;
View Options

nix/overlay.nix

Show All 36 Lines const {
threadInfo, threadInfo,
setErrorMessage, setErrorMessage,
} = props; } = props;
const modalContext = useModalContext(); const modalContext = useModalContext();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callDeleteThread = useServerCall(deleteThread); const callDeleteThread = useServerCall(deleteThread);
const accountPasswordInputRef = React.useRef();
const deleteThreadAction = React.useCallback(async () => { const deleteThreadAction = React.useCallback(async () => {
try { try {
const response = await callDeleteThread(threadInfo.id, accountPassword); const response = await callDeleteThread(threadInfo.id, accountPassword);
modalContext.clearModal(); modalContext.clearModal();
return response; return response;
} catch (e) { } catch (e) {
setErrorMessage( setErrorMessage(
e.message === 'invalid_credentials' ? 'wrong password' : 'unkown error', e.message === 'invalid_credentials' ? 'wrong password' : 'unkown error',
); );
setAccountPassword(''); setAccountPassword('');
// TODO: accountPasswordInput.focus() accountPasswordInputRef.current?.focus();
// (once ref is moved up to functional component)
throw e; throw e;
} }
}, [ }, [
accountPassword, accountPassword,
callDeleteThread, callDeleteThread,
modalContext, modalContext,
setAccountPassword, setAccountPassword,
setErrorMessage, setErrorMessage,
Show All 23 Lines <>
<div className={css.form_title}>Account password</div> <div className={css.form_title}>Account password</div>
<div className={css.form_content}> <div className={css.form_content}>
<input <input
type="password" type="password"
placeholder="Personal account password" placeholder="Personal account password"
value={accountPassword} value={accountPassword}
onChange={onChangeAccountPassword} onChange={onChangeAccountPassword}
disabled={inputDisabled} disabled={inputDisabled}
ref={accountPasswordInputRef}
/> />
</div> </div>
</div> </div>
<Button onClick={onDelete} variant="danger" disabled={inputDisabled}> <Button onClick={onDelete} variant="danger" disabled={inputDisabled}>
Delete Delete
</Button> </Button>
</> </>
); );
} }
export default ThreadSettingsDeleteTab; export default ThreadSettingsDeleteTab;