Paths

Table of Contentst

Differential D4335

[lib] Rename `threadIsWatched` to `isThreadWatched`
ClosedPublic
Actions

Authored by atul on Jun 22 2022, 3:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 6, 8:35 PM

	Unknown Object (File)
	Mon, May 6, 4:10 PM

	Unknown Object (File)
	Apr 17 2024, 8:51 PM

	Unknown Object (File)
	Apr 6 2024, 3:34 AM

	Unknown Object (File)
	Apr 4 2024, 5:13 PM

	Unknown Object (File)
	Apr 4 2024, 6:06 AM

	Unknown Object (File)
	Mar 31 2024, 6:27 AM

	Unknown Object (File)
	Mar 30 2024, 8:48 PM

View All 93 Files

Subscribers

Details

Reviewers

• jacek
tomek
• abosh

Commits

rCOMM79a5ee1c5c9c: [lib] Rename `threadIsWatched` to `isThreadWatched`

Summary

I think this is a better name.

This is an "opinionated" change, so open to abandoning if others disagree.

Depends on D4334

Test Plan

flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 22 2022, 3:16 PM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 22 2022, 3:16 PM

Harbormaster completed remote builds in B9898: Diff 13690.Jun 22 2022, 3:21 PM

atul requested review of this revision.Jun 22 2022, 3:21 PM

atul edited the summary of this revision. (Show Details)Jun 22 2022, 3:27 PM

atul added a parent revision: D4334: [lib] Rename `threadsToMessageIDsFromMessageInfos` to `mapThreadsToMessageIDsFromOrderedMessageInfos`.

atul added a child revision: D4336: [lib] Simplify logic in `mapThreadsToMessageIDsFromOrderedMessageInfos`.Jun 22 2022, 3:31 PM

tomek accepted this revision.Jun 23 2022, 3:59 AM

This revision is now accepted and ready to land.Jun 23 2022, 3:59 AM

Agree with this. threadIsWatched-type boolean names feel like they imply a value of true, since it sounds like "The thread is watched" versus "Is the thread watched?"

cherrypick before landing

This revision was landed with ongoing or failed builds.Jun 24 2022, 10:42 AM

Closed by commit rCOMM79a5ee1c5c9c: [lib] Rename `threadIsWatched` to `isThreadWatched` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM79a5ee1c5c9c: [lib] Rename `threadIsWatched` to `isThreadWatched`.

Harbormaster completed remote builds in B9959: Diff 13772.Jun 24 2022, 10:46 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

10 lines

Diff 13773

lib/reducers/message-reducer.js

Loading...