Pretty straightforward change.. reduces the number of lines of code (of which message-reducer has plenty)
Depends on D4335
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- june21 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 106 | It doesn't make too much sense to have threads[messageInfo.threadID] = threads[messageInfo.threadID] assignment - why do we need to assign a value to itself? (it might be confusing). Instead, we should be a little more explicit with our intention. | |
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 106 | I agree. | |