[lib] Merge identical action handlers in `message-reducer`
ClosedPublic
Actions

Authored by atul on Jun 22 2022, 8:33 PM.

Details

Reviewers

• jacek
tomek
• abosh

Commits

rCOMM379009f5003c: [lib] Merge identical action handlers in `message-reducer`

Summary

Saw that the handlers for each of these action types was identical, decided to merge them to reduce unnecessary repetition.

Depends on D4339

Test Plan

Close reading, will write some unit tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 22 2022, 8:33 PM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 22 2022, 8:33 PM

Harbormaster completed remote builds in B9912: Diff 13704.Jun 22 2022, 9:04 PM

atul requested review of this revision.Jun 22 2022, 9:04 PM

tomek accepted this revision.Jun 23 2022, 5:06 AM

This revision is now accepted and ready to land.Jun 23 2022, 5:06 AM

Good catch!

rebase after cherrypick and before landing

Harbormaster completed remote builds in B9962: Diff 13778.Jun 24 2022, 10:55 AM

Closed by commit rCOMM379009f5003c: [lib] Merge identical action handlers in `message-reducer` (authored by atul). · Explain WhyJun 24 2022, 11:06 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM379009f5003c: [lib] Merge identical action handlers in `message-reducer`.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

21 lines

Diff 13779

View Options

lib/reducers/message-reducer.js

	Show All 37 Lines
	)			)

	if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")			if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
	# Inside the docker build contex			# Inside the docker build contex
	set(_proto_path "grpc")			set(_proto_path "grpc")
	set(_shared_path "../shared")			set(_shared_path "../shared")
	else()			else()
	# Inside repo			# Inside repo
	set(_proto_path "../../native/cpp/CommonCpp/grpc")
	set(_shared_path "../../shared")			set(_shared_path "../../shared")
				set(_proto_path "../../shared/protos")
	endif()			endif()

	# Shared Comm protos			# Shared Comm protos
	add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}			add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
	${CMAKE_CURRENT_BINARY_DIR}/protos			${CMAKE_CURRENT_BINARY_DIR}/protos
	EXCLUDE_FROM_ALL			EXCLUDE_FROM_ALL
	)			)

	▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines

[lib] Merge identical action handlers in `message-reducer`ClosedPublicActions