[lib] Merge identical action handlers in `message-reducer`
ClosedPublic
Actions

Authored by atul on Jun 22 2022, 8:33 PM.

Tags

None

Referenced Files

	F1778298: D4340.id13704.diff
	Fri, May 17, 11:30 AM

	Unknown Object (File)
	Wed, May 8, 12:47 PM

	Unknown Object (File)
	Wed, May 1, 1:29 AM

	Unknown Object (File)
	Wed, May 1, 1:29 AM

	Unknown Object (File)
	Wed, May 1, 1:29 AM

	Unknown Object (File)
	Wed, May 1, 1:28 AM

	Unknown Object (File)
	Wed, May 1, 1:11 AM

	Unknown Object (File)
	Sat, Apr 20, 4:44 AM

View All 89 Files

Subscribers

• adrian

ashoat

Details

Reviewers

• jacek
tomek
• abosh

Commits

rCOMM379009f5003c: [lib] Merge identical action handlers in `message-reducer`

Summary

Saw that the handlers for each of these action types was identical, decided to merge them to reduce unnecessary repetition.

Depends on D4339

Test Plan

Close reading, will write some unit tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 22 2022, 8:33 PM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 22 2022, 8:33 PM

Harbormaster completed remote builds in B9912: Diff 13704.Jun 22 2022, 9:04 PM

atul requested review of this revision.Jun 22 2022, 9:04 PM

tomek accepted this revision.Jun 23 2022, 5:06 AM

This revision is now accepted and ready to land.Jun 23 2022, 5:06 AM

Good catch!

rebase after cherrypick and before landing

Harbormaster completed remote builds in B9962: Diff 13778.Jun 24 2022, 10:55 AM

Closed by commit rCOMM379009f5003c: [lib] Merge identical action handlers in `message-reducer` (authored by atul). · Explain WhyJun 24 2022, 11:06 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM379009f5003c: [lib] Merge identical action handlers in `message-reducer`.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

21 lines

Diff 13779

View Options

lib/reducers/message-reducer.js

[lib] Merge identical action handlers in `message-reducer`ClosedPublicActions