Page MenuHomePhabricator
Differential D4338

[lib] Return `mergeNewMessages(...)` directly where possible in `reduceMessageStore(...)`
ClosedPublic
Actions

Authored by atul on Jun 22 2022, 3:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 18, 8:08 PM
Unknown Object (File)
Wed, May 1, 1:29 AM
Unknown Object (File)
Wed, May 1, 1:29 AM
Unknown Object (File)
Wed, May 1, 1:29 AM
Unknown Object (File)
Wed, May 1, 1:28 AM
Unknown Object (File)
Wed, May 1, 1:11 AM
Unknown Object (File)
Apr 5 2024, 1:23 PM
Unknown Object (File)
Apr 3 2024, 7:26 AM
View All 61 Files
Subscribers
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• abosh
Commits
rCOMM8a9bef17c383: [lib] Return `mergeNewMessages(...)` directly where possible in…
Summary

Basically D4337, but for all the other mergeNewMessages(...) callsites.

This is just a noop refactor, trying to simplify message-reducer

Depends on D4337

Test Plan

Close reading, flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 22 2022, 3:50 PM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 22 2022, 3:50 PM
atul edited the summary of this revision. (Show Details)Jun 22 2022, 3:50 PM
atul added a parent revision: D4337: [lib] Return result of `mergeNewMessages(...) immediately for `fetchMessagesBeforeCursor.success`/`fetchMostReecentMessages.success` action types.
Harbormaster completed remote builds in B9901: Diff 13693.Jun 22 2022, 3:55 PM
atul requested review of this revision.Jun 22 2022, 3:55 PM
atul added a child revision: D4339: [web][landing] Fix miscellaneous CSS issues.Jun 22 2022, 8:34 PM
tomek accepted this revision.Jun 23 2022, 4:52 AM
This revision is now accepted and ready to land.Jun 23 2022, 4:52 AM
• abosh accepted this revision.Jun 23 2022, 8:09 AM
atul updated this revision to Diff 13776.Jun 24 2022, 10:46 AM

rebase after cherrypicking and before landing

This revision was landed with ongoing or failed builds.Jun 24 2022, 10:47 AM
Closed by commit rCOMM8a9bef17c383: [lib] Return `mergeNewMessages(...)` directly where possible in… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8a9bef17c383: [lib] Return `mergeNewMessages(...)` directly where possible in….
Harbormaster completed remote builds in B9961: Diff 13776.Jun 24 2022, 10:52 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
60 lines

Diff 13777

View Options

lib/reducers/message-reducer.js

Loading...