[lib] Return result of `mergeNewMessages(...) immediately for `fetchMessagesBeforeCursor.success`/`fetchMostReecentMessages.success` action types
ClosedPublic
Actions

Authored by atul on Jun 22 2022, 3:44 PM.

Details

Reviewers

• jacek
tomek
• abosh

Commits

rCOMM1a8c5e8c235a: [lib] Return result of `mergeNewMessages(...) immediately for…

Summary

We were previously destructuring the return value of mergeNewMessages(...) and passing the destructured variables into eg assertMessageStoreMessagesAreEqual(...).

But, we're not doing that anymore so we can just return directly and cut a few lines.

Depends on D4336

Test Plan

flow, close reading

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 22 2022, 3:44 PM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 22 2022, 3:44 PM

Harbormaster completed remote builds in B9900: Diff 13692.Jun 22 2022, 3:49 PM

atul requested review of this revision.Jun 22 2022, 3:49 PM

atul mentioned this in D4338: [lib] Return `mergeNewMessages(...)` directly where possible in `reduceMessageStore(...)`.Jun 22 2022, 3:50 PM

atul added a child revision: D4338: [lib] Return `mergeNewMessages(...)` directly where possible in `reduceMessageStore(...)`.Jun 22 2022, 3:50 PM

tomek accepted this revision.Jun 23 2022, 4:51 AM

This revision is now accepted and ready to land.Jun 23 2022, 4:51 AM

• abosh accepted this revision.Jun 23 2022, 8:08 AM

rebase after cherrypicking and before landing

This revision was landed with ongoing or failed builds.Jun 24 2022, 10:45 AM

Closed by commit rCOMM1a8c5e8c235a: [lib] Return result of `mergeNewMessages(...) immediately for… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM1a8c5e8c235a: [lib] Return result of `mergeNewMessages(...) immediately for….

Harbormaster completed remote builds in B9960: Diff 13774.Jun 24 2022, 10:50 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

6 lines

Diff 13775

View Options

lib/reducers/message-reducer.js

[lib] Return result of `mergeNewMessages(...) immediately for `fetchMessagesBeforeCursor.success`/`fetchMostReecentMessages.success` action typesClosedPublicActions