Page MenuHomePhabricator
Differential D4372

[services] Tunnelbroker - Add DYNAMODB_MAX_BATCH_ITEMS to Constants
ClosedPublic
Actions

Authored by • max on Jun 27 2022, 6:35 PM.
Tags
None
Referenced Files
F3673149: D4372.diff
Mon, Jan 6, 5:51 AM
Unknown Object (File)
Thu, Dec 26, 4:33 AM
Unknown Object (File)
Thu, Dec 26, 4:33 AM
Unknown Object (File)
Tue, Dec 17, 3:31 PM
Unknown Object (File)
Tue, Dec 17, 6:58 AM
Unknown Object (File)
Sun, Dec 15, 4:56 PM
Unknown Object (File)
Sun, Dec 15, 4:56 PM
Unknown Object (File)
Sun, Dec 15, 7:09 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
• karol
tomek
Commits
rCOMMd0ee24a91b52: [services] Tunnelbroker - Add DYNAMODB_MAX_BATCH_ITEMS to Constants
Summary

This diff is a part of the stack that introduces batch operations with the DynamoDB.

The DYNAMODB_MAX_BATCH_ITEMS constant represents the maximum allowable batch size for DynamoDB which is 25 items.

Linear task: ENG-1158

Test Plan

No testing is needed, it's just a constant.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Jun 27 2022, 6:35 PM
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJun 27 2022, 6:35 PM
• max edited the summary of this revision. (Show Details)Jun 27 2022, 6:37 PM
• max edited the test plan for this revision. (Show Details)
• max added reviewers: • karol, tomek.
• max edited the summary of this revision. (Show Details)
• max added a child revision: D4373: [services] Inner function to write to DynamoDB by batch.Jun 27 2022, 6:44 PM
Harbormaster completed remote builds in B10027: Diff 13866.Jun 27 2022, 6:45 PM
• max requested review of this revision.Jun 27 2022, 6:45 PM
• max mentioned this in D4373: [services] Inner function to write to DynamoDB by batch.Jun 27 2022, 6:50 PM
tomek accepted this revision.Jun 28 2022, 2:31 AM
This revision is now accepted and ready to land.Jun 28 2022, 2:31 AM
• max updated this revision to Diff 14135.Jul 4 2022, 3:54 PM

Slightly changed the constant name from MAX_DYNAMODB_BATCH_ITEMS to DYNAMODB_MAX_BATCH_ITEMS to be consistent across the all Constants file.

• max retitled this revision from [services] Tunnelbroker - Add MAX_DYNAMODB_BATCH_ITEMS to Constants to [services] Tunnelbroker - Add DYNAMODB_MAX_BATCH_ITEMS to Constants.Jul 4 2022, 3:54 PM
• max edited the summary of this revision. (Show Details)
• max added a child revision: D4436: [services] Tunnelbroker - Add exponential backoff related constants.Jul 4 2022, 4:02 PM
Harbormaster completed remote builds in B10243: Diff 14135.Jul 4 2022, 4:06 PM
• max added a child revision: D4476: [services] Tunnelbroker - Database function that removes messages by a batch using messageIDs and receiver DeviceID..Jul 7 2022, 7:46 AM
• max added a child revision: D4478: [services] Tunnelbroker - Add test for `removeMessageItemsByIDsForDeviceID` database function.Jul 7 2022, 8:37 AM
• max removed a child revision: D4373: [services] Inner function to write to DynamoDB by batch.Jul 11 2022, 2:02 AM
• karol accepted this revision.Jul 11 2022, 2:54 AM
Closed by commit rCOMMd0ee24a91b52: [services] Tunnelbroker - Add DYNAMODB_MAX_BATCH_ITEMS to Constants (authored by • max). · Explain WhyJul 12 2022, 3:59 PM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMd0ee24a91b52: [services] Tunnelbroker - Add DYNAMODB_MAX_BATCH_ITEMS to Constants.
• max mentioned this in rCOMMecd2f2cb68fe: [services] Inner function to write to DynamoDB by batch.Jul 25 2022, 6:34 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
2 lines

Diff 14415

View Options

services/tunnelbroker/src/Constants.h

Loading...