Details
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
services/tunnelbroker/src/Database/DatabaseManager.cpp | ||
---|---|---|
224–226 ↗ | (On Diff #14283) | Why do you prepend the name with cur? |
Rebased on parents changes. cur* variable were changed to current*.
services/tunnelbroker/src/Database/DatabaseManager.cpp | ||
---|---|---|
224–226 ↗ | (On Diff #14283) |
It's shorthand for 'current'. I've changed it to currentWriteRequest instead. |
Please fix the typo in this diff's title:
[services] Tunnelbroker - Database function that removes messages in a batch using the composite key and batchWrite
services/tunnelbroker/src/Database/DatabaseManager.cpp | ||
---|---|---|
216–227 ↗ | (On Diff #14386) | Maybe we could create deleteRequest before the for loop? And inside of that loop, we could just change the message id. That would result in a lot fewer allocations, right? Curious for your perspective |
services/tunnelbroker/src/Database/DatabaseManager.cpp | ||
---|---|---|
216–227 ↗ | (On Diff #14386) |
There is a reason why I've put it inside the loop and we re-create it every loop: We can possibly use it outside of the loop if we have the ability to clear the inner map, but SDK doesn't have a such method. In another way, we can use SetKey(...) instead of AddKey(...), but this changes don't provide any improvement in this case. |