Paths

Table of Contentst

[services] Tunnelbroker - Add test for putMessageItemsByBatch function
ClosedPublic
Actions

Authored by • max on Jun 28 2022, 6:41 AM.

Details

Reviewers

• karol
tomek

Commits

rCOMM6bc92df75a40: [services] Tunnelbroker - Add test for putMessageItemsByBatch function

Summary

This is a test for putMessageItemsByBatch function introduced in D4378.
In this test, we are creating a messages batch of 29 items and putting them into the database by the putMessageItemsByBatch function. We are expecting the
size of the found items would be the same as an item's batch size.

Linear task: ENG-1301

Test Plan

Run yarn test-tunnelbroker-service-dev-mode

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Jun 28 2022, 6:41 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJun 28 2022, 6:41 AM

• max edited the summary of this revision. (Show Details)Jun 28 2022, 6:42 AM

• max mentioned this in D4378: [services] Tunnelbroker - Function to put message items to the database by batch.Jun 28 2022, 6:44 AM

• max published this revision for review.Jun 28 2022, 6:46 AM

• max edited the summary of this revision. (Show Details)

• max added reviewers: • karol, tomek.

• max added a parent revision: D4378: [services] Tunnelbroker - Function to put message items to the database by batch.

Harbormaster completed remote builds in B10051: Diff 13893.Jun 28 2022, 6:51 AM

• max edited the summary of this revision. (Show Details)Jun 28 2022, 6:53 AM

tomek accepted this revision.Jun 29 2022, 4:46 AM

tomek added inline comments.

services/tunnelbroker/test/DatabaseManagerTest.cpp
107 ↗	(On Diff #13893)	It's probably not the batch size. The actual batch size is 25, isn't it? It is simply a number of items.
111 ↗	(On Diff #13893)	According to https://www.notion.so/commapp/C-coding-standards-8c9f22b4b16a41c3a868eb5f537db1de we should prefer braces initialization. Can we do this here?
137–138 ↗	(On Diff #13893)	Ideally, unrelated changes should be included in a separate diff

This revision is now accepted and ready to land.Jun 29 2022, 4:46 AM

• max mentioned this in rCOMM4f4d313523db: [services] Tunnelbroker - Function to put message items to the database by batch.Jul 25 2022, 6:58 AM

Rebase on the stack changes. Minor fixes by comments.

services/tunnelbroker/test/DatabaseManagerTest.cpp
107 ↗	(On Diff #13893)	It's probably not the batch size. The actual batch size is 25, isn't it? It is simply a number of items. Changed it to an `itemsSize`.
111 ↗	(On Diff #13893)	According to https://www.notion.so/commapp/C-coding-standards-8c9f22b4b16a41c3a868eb5f537db1de we should prefer braces initialization. Can we do this here? Yes, Sure. Changed it.
137–138 ↗	(On Diff #13893)	Ideally, unrelated changes should be included in a separate diff Yep, or should mark it somehow (make a comment about this or etc.). Sorry for this, linter made these changes.

Harbormaster completed remote builds in B10833: Diff 14896.Jul 25 2022, 4:12 PM

Closed by commit rCOMM6bc92df75a40: [services] Tunnelbroker - Add test for putMessageItemsByBatch function (authored by • max). · Explain WhyJul 26 2022, 2:52 PM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM6bc92df75a40: [services] Tunnelbroker - Add test for putMessageItemsByBatch function.

How were you able to test this?

yarn test-tunnelbroker-service-dev-mode

results in the following for me:

error Command "test-tunnelbroker-service-dev-mode" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

In D4377#133458, @atul wrote:
How were you able to test this?
yarn test-tunnelbroker-service-dev-mode
results in the following for me:
error Command "test-tunnelbroker-service-dev-mode" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Sorry, we've updated the list of commands in package.json while this diff was existing and the test plan was not updated. The updated command to run unit tests is cd /services && yarn run-unit-tests.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

test/

DatabaseManagerTest.cpp

42 lines

Diff 14996

View Options

services/tunnelbroker/test/DatabaseManagerTest.cpp

[services] Tunnelbroker - Add test for putMessageItemsByBatch functionClosedPublicActions