Paths

Table of Contentst

Differential D4475

[services] Tunnelbroker - Switching to use composite key in a messageItem entity
ClosedPublic
Actions

Authored by • max on Jul 7 2022, 6:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 4, 6:45 AM

	Unknown Object (File)
	Fri, Sep 27, 7:42 PM

	Unknown Object (File)
	Fri, Sep 27, 12:23 AM

	Unknown Object (File)
	Fri, Sep 27, 12:23 AM

	Unknown Object (File)
	Fri, Sep 27, 12:22 AM

	Unknown Object (File)
	Fri, Sep 27, 12:19 AM

	Unknown Object (File)
	Tue, Sep 17, 10:00 AM

	Unknown Object (File)
	Tue, Sep 17, 2:48 AM

Subscribers

Details

Reviewers

• karol
tomek

Commits

rCOMM0b12efcd9921: [services] Tunnelbroker - Switching to use composite key in a messageItem entity

Summary

To avoid possible message UUID collision and speedup batch messages deletion we should switch to using the composite key for the tunnelbroker-messages
table which will consist of messagesID as a Sort Key and toDeviceID as a Partition key.

This diff is a part of the stack and introduces changes to MessageItem database entity.

Linear task: ENG-1362

Test Plan

We can use the current MessageItem related tests located at services/tunnelbroker/test/DatabaseManagerTest.cpp.
When running yarn test-tunnelbroker-service-in-sandbox test should not fail including MessageItem related tests:

PutAndFoundMessageItemsStaticDataIsSame
PutAndFoundMessageItemsGeneratedDataIsSame
PutAndFoundByReceiverMessageItemsDataIsSame

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Jul 7 2022, 6:57 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 7 2022, 6:57 AM

• max added a parent revision: D4473: [services] Tunnelbroker - Switching to use composite key in a messages table in Terraform.Jul 7 2022, 6:58 AM

• max mentioned this in D4473: [services] Tunnelbroker - Switching to use composite key in a messages table in Terraform.Jul 7 2022, 7:03 AM

• max published this revision for review.Jul 7 2022, 7:05 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • karol, tomek.

Harbormaster completed remote builds in B10358: Diff 14266.Jul 7 2022, 7:09 AM

• max added a child revision: D4476: [services] Tunnelbroker - Database function that removes messages by a batch using messageIDs and receiver DeviceID..Jul 7 2022, 7:46 AM

• max added a child revision: D4478: [services] Tunnelbroker - Add test for `removeMessageItemsByIDsForDeviceID` database function.Jul 7 2022, 8:37 AM

tomek accepted this revision.Jul 8 2022, 2:25 AM

tomek added 1 blocking reviewer(s): • karol.

• karol accepted this revision.Jul 11 2022, 3:08 AM

This revision is now accepted and ready to land.Jul 11 2022, 3:08 AM

Closed by commit rCOMM0b12efcd9921: [services] Tunnelbroker - Switching to use composite key in a messageItem entity (authored by • max). · Explain WhyJul 25 2022, 6:35 AM

This revision was automatically updated to reflect the committed changes.

• max mentioned this in rCOMM43cc1b683217: [services] Tunnelbroker - Switching to use composite key in a messages table in….

• max added a commit: rCOMM0b12efcd9921: [services] Tunnelbroker - Switching to use composite key in a messageItem entity.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

Database/

MessageItem.cpp

5 lines

Diff 14842

services/tunnelbroker/src/Database/MessageItem.cpp

Loading...