Paths

Table of Contentst

-
services/tunnelbroker/src/
-
tunnelbroker/
-
src/
-
Constants.h

[services] Tunnelbroker - Add exponential backoff related constants
ClosedPublic
Actions

Authored by • max on Jul 4 2022, 4:02 PM.

Details

Reviewers

• karol
tomek

Commits

rCOMMf074a9c13b3b: [services] Tunnelbroker - Add exponential backoff related constants

Summary

This diff introduces additional constants for the function for exponential backoff timeout which will be used in DynamoDB batch write operation and throttling. The function itself is introduced in D4373, and the usage of these constants is in D4378.

DYNAMODB_BACKOFF_FIRST_RETRY_DELAY - Is an exponential backoff first delay in milliseconds.
DYNAMODB_MAX_BACKOFF_TIME - Maximum delay timeout after which the operation would be considered as failed.

Test Plan

No testing is needed, it's just a constant.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Jul 4 2022, 4:02 PM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 4 2022, 4:02 PM

• max added a parent revision: D4372: [services] Tunnelbroker - Add DYNAMODB_MAX_BATCH_ITEMS to Constants.Jul 4 2022, 4:02 PM

• max added reviewers: • karol, tomek.

Harbormaster completed remote builds in B10244: Diff 14136.Jul 4 2022, 4:14 PM

• max added a child revision: D4373: [services] Inner function to write to DynamoDB by batch.Jul 5 2022, 5:23 AM

• max added a child revision: D4378: [services] Tunnelbroker - Function to put message items to the database by batch.Jul 5 2022, 5:49 AM

• max published this revision for review.Jul 5 2022, 5:53 AM

• max edited the summary of this revision. (Show Details)

Where did these values come from?

In D4436#126148, @karol-bisztyga wrote:

Where did these values come from?

Thanks for questioning this!
It's an optimized value from my perspective.
DYNAMODB_BACKOFF_STEP - the 5 ms with an exponential backoff should be a good value in case we will experience a throttling from the AWS.
DYNAMODB_MAX_BACKOFF_TIME - 10 sec as a maximum wait time until we consider the operation is failed seems to be enough too. From my perspective, the maximum wait time from the database should not be greater than 5-10 seconds. To avoid "flooding" the database by the requests in case of the database is down or has performance issues. But curious for any thoughts about this.

• max added a child revision: D4476: [services] Tunnelbroker - Database function that removes messages by a batch using messageIDs and receiver DeviceID..Jul 7 2022, 7:46 AM

• max added a child revision: D4478: [services] Tunnelbroker - Add test for `removeMessageItemsByIDsForDeviceID` database function.Jul 7 2022, 8:37 AM

I've found a document https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Programming.Errors.html#Programming.Errors.RetryAndBackoff where it is stated that

In addition to simple retries, each AWS SDK implements an exponential backoff algorithm for better flow control.

So it seems the SDK should include this algorithm. Can you check if this is the case?

services/tunnelbroker/src/Constants.h
12 ↗	(On Diff #14136)	In the document they present an example For example, up to 50 milliseconds before the first retry So maybe we should increase this number. 5ms sounds like a really small delay in network world. Also, in exponential backoff we multiply the delay after each retry, so naming it a `step` may suggest that it is increased instead of multiplied. A better name could be e.g. `DYNAMODB_BACKOFF_FIRST_RETRY_DELAY`
13 ↗	(On Diff #14136)	In the linked document, they suggest to Set the maximum number of retries to stop around one minute. But I guess setting it to something smaller is ok

This revision now requires changes to proceed.Jul 8 2022, 2:04 AM

tomek mentioned this in D4373: [services] Inner function to write to DynamoDB by batch.Jul 8 2022, 2:13 AM

• max planned changes to this revision.Jul 11 2022, 1:06 AM

DYNAMODB_BACKOFF_STEP changed to DYNAMODB_BACKOFF_FIRST_RETRY_DELAY. Value is increased from 5 ms to 50 ms for the first step.

• max marked 2 inline comments as done.Jul 11 2022, 1:27 AM

• max added inline comments.

services/tunnelbroker/src/Constants.h
12 ↗	(On Diff #14136)	In the document they present an example For example, up to 50 milliseconds before the first retry So maybe we should increase this number. 5ms sounds like a really small delay in network world. Also, in exponential backoff we multiply the delay after each retry, so naming it a `step` may suggest that it is increased instead of multiplied. A better name could be e.g. `DYNAMODB_BACKOFF_FIRST_RETRY_DELAY` I've changed the constant name and increased the value to 50ms due to the algorithm changes in D4373
13 ↗	(On Diff #14136)	In the linked document, they suggest to Set the maximum number of retries to stop around one minute. But I guess setting it to something smaller is ok I think in our case minute is too much. In case of high usage, it will cause a flood of "waiting" requests if the database becomes unavailable for some time. If the usage scenario provides rare requests to the DB it will be ok to go with some big amount of time, but in our case small is better, because it's better to return a temporary error to the client instead of flooding the database with the requests. From my perspective is: higher potential usage - smaller timeout.

• max edited the summary of this revision. (Show Details)Jul 11 2022, 1:28 AM

Harbormaster completed remote builds in B10438: Diff 14382.Jul 11 2022, 1:31 AM

• max removed a child revision: D4373: [services] Inner function to write to DynamoDB by batch.Jul 11 2022, 2:02 AM

In D4436#127443, @palys-swm wrote:

I've found a document https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Programming.Errors.html#Programming.Errors.RetryAndBackoff where it is stated that

In addition to simple retries, each AWS SDK implements an exponential backoff algorithm for better flow control.

So it seems the SDK should include this algorithm. Can you check if this is the case?

I saw this page too and checked the C++ SDK code and seems that we should implement it by our-self in case of use in the batch writes scenario. Even the demo code for batchWrite from AWS C++ SDK suggests implementing it.

• karol accepted this revision.Jul 11 2022, 2:56 AM

tomek accepted this revision.Jul 18 2022, 6:52 AM

This revision is now accepted and ready to land.Jul 18 2022, 6:52 AM

Closed by commit rCOMMf074a9c13b3b: [services] Tunnelbroker - Add exponential backoff related constants (authored by • max). · Explain WhyJul 18 2022, 7:03 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMf074a9c13b3b: [services] Tunnelbroker - Add exponential backoff related constants.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

Constants.h

2 lines

Diff 14575

View Options

services/tunnelbroker/src/Constants.h

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

[services] Tunnelbroker - Add exponential backoff related constantsClosedPublicActions