Differential D4379

[services] Tests - Read port from the env vars
ClosedPublic
Actions

Authored by • karol on Jun 28 2022, 7:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 6, 7:23 PM

	Unknown Object (File)
	Sat, Jul 6, 11:02 AM

	Unknown Object (File)
	Sat, Jul 6, 11:02 AM

	Unknown Object (File)
	Sat, Jul 6, 11:02 AM

	Unknown Object (File)
	Sat, Jul 6, 11:02 AM

	Unknown Object (File)
	Sat, Jul 6, 11:01 AM

	Unknown Object (File)
	Sat, Jul 6, 11:01 AM

	Unknown Object (File)
	Sat, Jul 6, 11:01 AM

Subscribers

Details

Reviewers

Commits

rCOMM02dae1934da6: [services] Tests - Read port from the env vars

Summary

Depends on D4341

Raised in https://phab.comm.dev/D4252#121260

It is better to read the ports from the env vars and limit the number of places where we specify them to the minimum - ideally just one.

Test Plan

Services should work as usual.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Jun 28 2022, 7:32 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 28 2022, 7:32 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 28 2022, 7:33 AM

Harbormaster failed remote builds in B10053: Diff 13902!

• karol mentioned this in D4228: [services] Tests - Add pull backup.Jun 28 2022, 7:47 AM

• karol mentioned this in D4252: [services] Tests - Add backup test logic.

CI fails because we use raw commands in CI instead of the package json scripts.

tomek accepted this revision.Jun 29 2022, 3:30 AM

tomek added inline comments.

services/commtest/tests/backup_test.rs
25 ↗	(On Diff #13902)	Have you formatted this line? It seems too long.
services/scripts/run_integration_tests.sh
42–44 ↗	(On Diff #13902)	Could you explain what happens here?

This revision is now accepted and ready to land.Jun 29 2022, 3:30 AM

rebase

Harbormaster failed remote builds in B10101: Diff 13962!Jun 29 2022, 6:09 AM

• karol added a child revision: D4413: [services] Tests - run cargo fmt.Jun 30 2022, 7:09 AM

rebase

Harbormaster completed remote builds in B10196: Diff 14074.Jul 1 2022, 2:32 AM

rebase

Harbormaster failed remote builds in B10313: Diff 14219!Jul 6 2022, 2:48 AM

rebase

Harbormaster failed remote builds in B10409: Diff 14319!Jul 8 2022, 1:46 AM

format

Harbormaster failed remote builds in B10410: Diff 14320!Jul 8 2022, 1:52 AM

• karol added inline comments.Jul 8 2022, 1:55 AM

services/scripts/run_integration_tests.sh
42–44 ↗	(On Diff #13902)	I couldn't access env variables from this file without that wrapper. In order to build functionality, that we need to export variables into the environment so that any of the child processes can use it, we would need the help of allexport to import all the variables.

This revision was landed with ongoing or failed builds.Jul 8 2022, 2:31 AM

Closed by commit rCOMM02dae1934da6: [services] Tests - Read port from the env vars (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM02dae1934da6: [services] Tests - Read port from the env vars.

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

6 lines

4 lines

scripts/

run_integration_tests.sh

4 lines

Diff 14350

services/commtest/tests/backup_test.rs

Loading...

services/commtest/tests/blob_test.rs

Loading...

services/scripts/run_integration_tests.sh

Loading...