Details

Reviewers

tomek
varun

Commits

rCOMMa531a7b440e3: [services] Tests - Blob - Add test logic

Summary

Depends on D4276

Adding test logic for the blob test. This code invoked methods introduced in D4274 D4275 and D4276.

Test Plan

cd services
yarn run-integration-tests blob

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

• karol requested review of this revision.Jun 15 2022, 3:50 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun.

tomek added inline comments.

services/commtest/tests/blob_test.rs
42–52 ↗	(On Diff #13520)	What do you think about using `enumerate`?
55–57 ↗	(On Diff #13520)	Shouldn't we check if the items were removed?

varun requested changes to this revision.Jun 21 2022, 8:40 PM

varun added inline comments.

services/commtest/tests/blob_test.rs
58 ↗	(On Diff #13520)	we should have an assert here

This revision now requires changes to proceed.Jun 21 2022, 8:40 PM

services/commtest/tests/blob_test.rs
20–34 ↗	(On Diff #13520)	use byte size lib like in the backup test
42–52 ↗	(On Diff #13520)	looks good! THX
46 ↗	(On Diff #13520)	`assert_eq`
55–57 ↗	(On Diff #13520)	I think yes, we can run `get` again
58 ↗	(On Diff #13520)	What assert? Can you be more specific? I don't understand.

address feedback

varun added inline comments.

services/commtest/tests/blob_test.rs
58 ↗	(On Diff #13520)	nvm. i assume that you're using asserts in the `remove::run` function to check that the state matches the expectation

This revision is now accepted and ready to land.Jun 29 2022, 3:23 PM

services/commtest/tests/blob_test.rs
58 ↗	(On Diff #13520)	sorry, ignore my last comment. you added the assert i was initially looking for to check that the items were removed successfully