Page MenuHomePhabricator
Differential D4277

[services] Tests - Blob - Add test logic
ClosedPublic
Actions

Authored by • karol on Jun 15 2022, 3:11 AM.
Tags
None
Referenced Files
F3499119: D4277.diff
Thu, Dec 19, 10:36 PM
Unknown Object (File)
Mon, Dec 16, 12:26 AM
Unknown Object (File)
Sun, Dec 15, 9:50 AM
Unknown Object (File)
Sun, Dec 15, 9:50 AM
Unknown Object (File)
Sun, Dec 15, 9:50 AM
Unknown Object (File)
Sun, Dec 15, 9:50 AM
Unknown Object (File)
Sun, Dec 15, 9:50 AM
Unknown Object (File)
Sun, Dec 15, 9:50 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMMa531a7b440e3: [services] Tests - Blob - Add test logic
Summary

Depends on D4276

Adding test logic for the blob test. This code invoked methods introduced in D4274 D4275 and D4276.

Test Plan
cd services
yarn run-integration-tests blob

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Jun 15 2022, 3:11 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 15 2022, 3:11 AM
Harbormaster completed remote builds in B9768: Diff 13520.Jun 15 2022, 3:50 AM
• karol requested review of this revision.Jun 15 2022, 3:50 AM
• karol edited the summary of this revision. (Show Details)Jun 15 2022, 4:28 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
• karol added a parent revision: D4276: [services] Tests - Blob - Add Remove.
tomek accepted this revision.Jun 20 2022, 6:04 AM
tomek added inline comments.
services/commtest/tests/blob_test.rs
42–52

What do you think about using enumerate?

55–57

Shouldn't we check if the items were removed?

varun requested changes to this revision.Jun 21 2022, 8:40 PM
varun added inline comments.
services/commtest/tests/blob_test.rs
58

we should have an assert here

This revision now requires changes to proceed.Jun 21 2022, 8:40 PM
• karol added a child revision: D4320: [services] Backup - Add data hash to the log item.Jun 22 2022, 5:39 AM
• karol added inline comments.Jun 29 2022, 6:07 AM
services/commtest/tests/blob_test.rs
20–34

use byte size lib like in the backup test

42–52

looks good! THX

46

assert_eq

55–57

I think yes, we can run get again

58

What assert? Can you be more specific? I don't understand.

• karol updated this revision to Diff 13961.Jun 29 2022, 6:07 AM
• karol edited the summary of this revision. (Show Details)

address feedback

Harbormaster failed remote builds in B10100: Diff 13961!Jun 29 2022, 6:08 AM
varun accepted this revision.Jun 29 2022, 3:23 PM
varun added inline comments.
services/commtest/tests/blob_test.rs
58

nvm. i assume that you're using asserts in the remove::run function to check that the state matches the expectation

This revision is now accepted and ready to land.Jun 29 2022, 3:23 PM
varun added inline comments.Jun 29 2022, 3:26 PM
services/commtest/tests/blob_test.rs
58

sorry, ignore my last comment. you added the assert i was initially looking for to check that the items were removed successfully

• karol updated this revision to Diff 14032.Jun 30 2022, 6:27 AM

use functions with scope

ashoat added inline comments.Jun 30 2022, 6:48 AM
services/commtest/tests/blob_test.rs
25 ↗(On Diff #14032)

Why are these lines so long? Don't we have Rust configured to limit line length to 80 chars?

Harbormaster failed remote builds in B10162: Diff 14032!Jun 30 2022, 8:42 AM
Harbormaster completed remote builds in B10162: Diff 14032.Jun 30 2022, 8:47 AM
• karol updated this revision to Diff 14080.Jul 1 2022, 2:46 AM

run fmt

services/commtest/tests/blob_test.rs
25 ↗(On Diff #14032)

something is wrong with the hooks/formatter

Harbormaster completed remote builds in B10202: Diff 14080.Jul 1 2022, 2:58 AM
• karol updated this revision to Diff 14310.Jul 8 2022, 12:28 AM

rebase

Harbormaster failed remote builds in B10400: Diff 14310!Jul 8 2022, 12:28 AM
This revision was landed with ongoing or failed builds.Jul 8 2022, 2:30 AM
Closed by commit rCOMMa531a7b440e3: [services] Tests - Blob - Add test logic (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMa531a7b440e3: [services] Tests - Blob - Add test logic.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
54 lines

Diff 13520

View Options

services/commtest/tests/blob_test.rs

Loading...