Details
Details
- Reviewers
tomek varun - Commits
- rCOMMa531a7b440e3: [services] Tests - Blob - Add test logic
cd services yarn run-integration-tests blob
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/commtest/tests/blob_test.rs | ||
|---|---|---|
| 58 ↗ | (On Diff #13520) | we should have an assert here |
| services/commtest/tests/blob_test.rs | ||
|---|---|---|
| 20–34 ↗ | (On Diff #13520) | use byte size lib like in the backup test |
| 42–52 ↗ | (On Diff #13520) | looks good! THX |
| 46 ↗ | (On Diff #13520) | assert_eq |
| 55–57 ↗ | (On Diff #13520) | I think yes, we can run get again |
| 58 ↗ | (On Diff #13520) | What assert? Can you be more specific? I don't understand. |
| services/commtest/tests/blob_test.rs | ||
|---|---|---|
| 58 ↗ | (On Diff #13520) | nvm. i assume that you're using asserts in the remove::run function to check that the state matches the expectation |
| services/commtest/tests/blob_test.rs | ||
|---|---|---|
| 58 ↗ | (On Diff #13520) | sorry, ignore my last comment. you added the assert i was initially looking for to check that the items were removed successfully |
| services/commtest/tests/blob_test.rs | ||
|---|---|---|
| 25 | Why are these lines so long? Don't we have Rust configured to limit line length to 80 chars? | |
Comment Actions
run fmt
| services/commtest/tests/blob_test.rs | ||
|---|---|---|
| 25 | something is wrong with the hooks/formatter | |