Page MenuHomePhabricator
Differential D4273

[services] Tests - Blob - Add blob utils
ClosedPublic
Actions

Authored by • karol on Jun 15 2022, 3:09 AM.
Tags
None
Referenced Files
F2209585: D4273.id14336.diff
Sun, Jul 7, 5:57 PM
Unknown Object (File)
Thu, Jul 4, 12:20 AM
Unknown Object (File)
Mon, Jul 1, 2:07 AM
Unknown Object (File)
Thu, Jun 27, 11:32 AM
Unknown Object (File)
Wed, Jun 26, 7:31 PM
Unknown Object (File)
Wed, Jun 26, 2:26 PM
Unknown Object (File)
Wed, Jun 26, 2:09 PM
Unknown Object (File)
Wed, Jun 26, 7:34 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMM2bb4a9a2cd31: [services] Tests - Blob - Add blob utils
Summary

Depends on D4272

Adding blob utils containing some stuff that will be used across all blob tests. BlobData is a helper structure for keeping the data that describes the blob record.

Test Plan

None really. Itself, it does not do anything special. Will be used later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Jun 15 2022, 3:09 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 15 2022, 3:09 AM
Harbormaster completed remote builds in B9764: Diff 13516.Jun 15 2022, 3:29 AM
• karol requested review of this revision.Jun 15 2022, 3:29 AM
• karol edited the summary of this revision. (Show Details)Jun 15 2022, 3:29 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
• karol added a parent revision: D4272: [services] Add teardown script.
• karol added a child revision: D4274: [services] Tests - Blob - Add Put.Jun 15 2022, 4:35 AM
varun accepted this revision.Jun 15 2022, 8:53 AM
varun added inline comments.
services/commtest/tests/blob/blob_utils.rs
11 ↗(On Diff #13516)

nit: chunk_sizes ?

This revision is now accepted and ready to land.Jun 15 2022, 8:53 AM
tomek accepted this revision.Jun 20 2022, 5:41 AM
• karol updated this revision to Diff 14023.Jun 30 2022, 3:01 AM
• karol edited the summary of this revision. (Show Details)

retrigger CI

Harbormaster failed remote builds in B10153: Diff 14023!Jun 30 2022, 8:17 AM
Harbormaster completed remote builds in B10153: Diff 14023.Jun 30 2022, 8:48 AM
• karol added inline comments.Jul 8 2022, 12:25 AM
services/commtest/tests/blob/blob_utils.rs
11 ↗(On Diff #13516)

I don't know, I'd say chunks' sizes because it refers to every chunk's size.

Closed by commit rCOMM2bb4a9a2cd31: [services] Tests - Blob - Add blob utils (authored by • karol). · Explain WhyJul 8 2022, 2:30 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM2bb4a9a2cd31: [services] Tests - Blob - Add blob utils.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
blob/
12 lines

Diff 14336

View Options

services/commtest/tests/blob/blob_utils.rs

Loading...