Page MenuHomePhabricator
Differential D4412

[services] Backup - Send Log - Check the real item size
ClosedPublic
Actions

Authored by • karol on Jun 30 2022, 3:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 6, 4:45 PM
Unknown Object (File)
Sat, Jul 6, 4:45 PM
Unknown Object (File)
Sat, Jul 6, 4:45 PM
Unknown Object (File)
Sun, Jun 30, 3:07 PM
Unknown Object (File)
Sat, Jun 29, 10:43 PM
Unknown Object (File)
Sat, Jun 29, 6:08 PM
Unknown Object (File)
Sat, Jun 29, 12:48 AM
Unknown Object (File)
Thu, Jun 27, 11:43 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
Commits
rCOMMcc745f3bbc81: [services] Backup - Send Log - Check the real item size
Summary

Depends on D4411

https://linear.app/comm/issue/ENG-1288/properly-handle-the-dynamodb-item-size-limit

Test Plan

Services build, for now this went out of sync with the integration tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Jun 30 2022, 3:48 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 30 2022, 3:48 AM
• karol added a child revision: D4322: [services] Backup - Add data hash to database manager.Jun 30 2022, 3:49 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D4411: [services] Backup - Send Log - Use separate variables for value and blob holder.
• karol published this revision for review.Jun 30 2022, 5:49 AM

unrelated keyserver build hangs

atul added a comment.Jun 30 2022, 6:41 AM
In D4412#124828, @karol-bisztyga wrote:

unrelated keyserver build hangs

Should be resolved if you pull latest master, specifically this diff: https://github.com/CommE2E/comm/commit/7b2de11bb44ce965c789cdc48086fa17d0053235

Running an agent with the old agentID for now to clear the queue though

Harbormaster failed remote builds in B10156: Diff 14026!Jun 30 2022, 8:42 AM
Harbormaster completed remote builds in B10156: Diff 14026.Jun 30 2022, 8:48 AM
tomek accepted this revision.Jun 30 2022, 9:19 AM
tomek added inline comments.
services/backup/src/Reactors/server/SendLogReactor.cpp
24–27 ↗(On Diff #14026)

This notation is ok, but maybe we can use something even more obvious?

This revision is now accepted and ready to land.Jun 30 2022, 9:19 AM
• karol updated this revision to Diff 14312.Jul 8 2022, 12:35 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)

change err msg

Harbormaster failed remote builds in B10402: Diff 14312!Jul 8 2022, 12:35 AM
This revision was landed with ongoing or failed builds.Jul 8 2022, 2:30 AM
Closed by commit rCOMMcc745f3bbc81: [services] Backup - Send Log - Check the real item size (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMcc745f3bbc81: [services] Backup - Send Log - Check the real item size.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
server/
7 lines

Diff 14344

View Options

services/backup/src/Reactors/server/SendLogReactor.cpp

Loading...