Page MenuHomePhabricator
Differential D4276

[services] Tests - Blob - Add Remove
ClosedPublic
Actions

Authored by • karol on Jun 15 2022, 3:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 1, 12:46 PM
Unknown Object (File)
Sun, Jun 30, 5:20 PM
Unknown Object (File)
Sun, Jun 30, 7:03 AM
Unknown Object (File)
Thu, Jun 27, 10:52 AM
Unknown Object (File)
Wed, Jun 26, 7:34 AM
Unknown Object (File)
Wed, Jun 26, 7:34 AM
Unknown Object (File)
Wed, Jun 26, 7:34 AM
Unknown Object (File)
Wed, Jun 26, 7:34 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMM02caf33e16fe: [services] Tests - Blob - Add Remove
Summary

Depends on D4275

Adding Remove method to blob's tests.

Test Plan

For now, this method's not invoked. The Rust project should build normally.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Jun 15 2022, 3:10 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 15 2022, 3:10 AM
Harbormaster completed remote builds in B9767: Diff 13519.Jun 15 2022, 3:44 AM
• karol requested review of this revision.Jun 15 2022, 3:44 AM
• karol added a child revision: D4277: [services] Tests - Blob - Add test logic.Jun 15 2022, 4:28 AM
• karol edited the summary of this revision. (Show Details)Jun 15 2022, 4:36 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
• karol added a parent revision: D4275: [services] Tests - Blob - Add Get.
tomek accepted this revision.Jun 20 2022, 5:59 AM
varun accepted this revision.Jun 21 2022, 8:39 PM
varun added inline comments.
services/commtest/tests/blob/remove.rs
6–10 ↗(On Diff #13519)

same feedback about organization as in D4275

This revision is now accepted and ready to land.Jun 21 2022, 8:39 PM
• karol updated this revision to Diff 14079.Jul 1 2022, 2:44 AM
• karol edited the summary of this revision. (Show Details)

group uses

Harbormaster completed remote builds in B10201: Diff 14079.Jul 1 2022, 2:56 AM
Closed by commit rCOMM02caf33e16fe: [services] Tests - Blob - Add Remove (authored by • karol). · Explain WhyJul 8 2022, 2:30 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM02caf33e16fe: [services] Tests - Blob - Add Remove.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
blob/
24 lines

Diff 14339

View Options

services/commtest/tests/blob/remove.rs

Loading...