Should fix iOS build, as headers
will be able to be found
Depends on D4448
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- joringer/andriod
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Looks like the issue for the iOS build was:
fatal error: 'CryptoTools/CryptoModule.h' file not found #include <CryptoTools/CryptoModule.h>
Comment Actions
Yea, a bit odd, since "$(SRCROOT)/../cpp/CommonCpp", should resolve to native/cpp/CommonCpp, which should be the correct path
Comment Actions
Figured out why this is failing, The Compiled Sources don't inherit the HEADER_SEARCH_PATH, that only gets used by files that are directly included into the project. I have to manually had the -I../cpp/CommonCpp path to each of them
Comment Actions
For the xcode project, I probably over-did it on header search paths, but didn't want to painfully determine which ones actually needed it, since I don't have a local environment yet
Comment Actions
Resigning since I'm usually not a good person to set as a first-pass reviewer. Exceptions here
Comment Actions
Looks good since everything builds. IIRC in the past opening up an Xcode project/workspace in the Xcode GUI could sometimes "throw away" changes made "manually" to .pbxproj files.
I'll try patching this in locally, building in Xcode GUI, and seeing what happens
Comment Actions
I made all the changes through the GUI, just to make sure I didn't invalidate something.
Comment Actions
Ah gotcha, thanks for clarifying. Wasn't sure because of
Unfortunately until I get setup with a Apple developer account, I can't really make use of XCode directly yet
in another diff.
Comment Actions
ah dang, while the Comm target builds successfully... the NotificationService target fails
going to quickly add NotificationService target to the CI, sorry about that
Getting the following:
/Users/atul/comm/native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp error build: Build input file cannot be found: '/Users/atul/comm/native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp'
Comment Actions
NotificationServices should build now, in the process of getting my apple account in order
Comment Actions
I patched this differential, run yarn cleaninstall, attempted to build app for Physical device and I experienced the same error as @atul . However I quickly found a solution to this problem. I needed to change two lines:
- <olm/session.hh> to "olm/session.hh" in CryptoModule.cpp
- <sqlite_orm.h> to "sqlite_orm.h" in SQLiteQueryExecutor.cpp.
We either need to introduce those changes or (more probably) find a reason why using <> instead of "" for includes fails in new settings. I am not sure if it is helpful but sqlite_orm.h is a 3-rd party library but it is included in our repo as a regular file.
Comment Actions
Need to update this, as it now has conflicts with master. And solving the header structure has been de-prioritized