Page MenuHomePhabricator
Differential D4498

[services] Tunnelbroker - Add Corrosion to CMakeLists
ClosedPublic
Actions

Authored by • max on Jul 11 2022, 4:42 AM.
Tags
None
Referenced Files
F2213144: D4498.diff
Mon, Jul 8, 11:14 AM
Unknown Object (File)
Sat, Jul 6, 4:59 PM
Unknown Object (File)
Wed, Jul 3, 12:57 PM
Unknown Object (File)
Tue, Jun 18, 2:23 PM
Unknown Object (File)
Tue, Jun 18, 2:23 PM
Unknown Object (File)
Tue, Jun 18, 2:22 PM
Unknown Object (File)
Tue, Jun 18, 2:19 PM
Unknown Object (File)
Fri, Jun 14, 12:36 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• jon
• karol
tomek

Details

Reviewers
• karol
tomek
varun
• jon
Commits
rCOMM39c0e7fb4bce: [services] Tunnelbroker - Add Corrosion to CMakeLists
Summary

Add Corrosion tool for Rust and Cargo integration to CMakeLists.txt.

Linear task: ENG-1329

Test Plan

Running run-tunnelbroker-service and building the Tunnelbroker service using the CMakeLists resulted in success.

Diff Detail

Repository
rCOMM Comm
Branch
append-corrosion-to-cmakelists
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Jul 11 2022, 4:42 AM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 11 2022, 4:42 AM
• max added parent revisions: D4497: [services] Tunnelbroker - Install Rust and Corrosion in Dockerfile, D4496: [services] Tunnelbroker - Add Corrosion installation script.Jul 11 2022, 4:43 AM
• max mentioned this in D4496: [services] Tunnelbroker - Add Corrosion installation script.Jul 11 2022, 4:52 AM
Harbormaster completed remote builds in B10446: Diff 14390.Jul 11 2022, 4:54 AM
• max mentioned this in D4497: [services] Tunnelbroker - Install Rust and Corrosion in Dockerfile.Jul 11 2022, 4:55 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: • karol, tomek, varun.
• max published this revision for review.Jul 11 2022, 5:05 AM
ashoat added a reviewer: • jon. ashoat removed 1 blocking reviewer(s): tomek.Jul 11 2022, 6:15 AM
ashoat added a subscriber: • jon.

Adding @jonringer-comm since it's CMake/Rust-related. Also removed @palys-swm as blocking to give him a break :)

• jon accepted this revision.Jul 11 2022, 8:06 AM

LGTM

varun accepted this revision.Jul 12 2022, 12:00 PM
This revision is now accepted and ready to land.Jul 12 2022, 12:00 PM
• max mentioned this in rCOMM2d4977700846: [services] Tunnelbroker - Add Corrosion installation script.Jul 14 2022, 6:23 AM
Closed by commit rCOMM39c0e7fb4bce: [services] Tunnelbroker - Add Corrosion to CMakeLists (authored by • max). · Explain WhyJul 14 2022, 6:25 AM
This revision was automatically updated to reflect the committed changes.
• max mentioned this in rCOMM6271350404db: [services] Tunnelbroker - Install Rust and Corrosion in Dockerfile.
• max added a commit: rCOMM39c0e7fb4bce: [services] Tunnelbroker - Add Corrosion to CMakeLists.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
1 line

Diff 14390

View Options

services/tunnelbroker/CMakeLists.txt

Loading...