Lint android's CMakeLists.txt
Depends on D4564
Details
Details
nix develop cmake-lint native/android/app/CMakeLists.txt ./gradlew bundleRelease --no-daemon # ensure build still passes
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Defining the dirs separately makes a lot of sense – I assume you did that manually @jonringer-comm, but will be very impressed with the Linter if it does that automatically!
Separately, noticed that some of the lines here are longer than 80 chars, but for filenames I think it makes sense... it definitely hurts readability to split those across lines. Ideally we can have something that works like Prettier's printWidth setting, which generally limits line length but excludes import lines.
Comment Actions
noticed that some of the lines here are longer than 80 chars, but for filenames I think it makes sense...
Strongly agree we shouldn't try splitting filenames in weird ways to stay within 80 char limit
Comment Actions
I assume you did that manually @jonringer-comm
I did it manually. The cmake-format command will mostly do whitespace and paren placement.