Paths

Table of Contentst

Differential D4590

[services] Blob - Remove couts or replace them with glog
ClosedPublic
Actions

Authored by • karol on Jul 21 2022, 10:45 AM.

Tags

None

Referenced Files

	F32564179: D4590.1767366498.diff
	Thu, Jan 1, 3:08 PM

Subscribers

Details

Reviewers

tomek
• max

Commits

rCOMMe955e113c436: [services] Blob - Remove couts or replace them with glog

Summary

Depends on D4589

Adding an initialization of the glog functionalities.
Removing std::couts or replacing them with glog functions for the blob service.

Test Plan

cd services
yarn run-blob-service-in-sandbox

Builds ok

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jul 21 2022, 10:45 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 21 2022, 10:45 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 10:46 AM

Harbormaster failed remote builds in B10710: Diff 14749!

• karol edited the summary of this revision. (Show Details)Jul 21 2022, 11:03 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D4589: [services] Backup - Remove couts or replace them with glog.

• karol added a child revision: D4591: [services] Lib - Remove couts or replace them with glog.

CI

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 11:04 AM

Harbormaster failed remote builds in B10722: Diff 14761!

Services built properly

• max accepted this revision.Jul 21 2022, 2:01 PM

• max added inline comments.

services/blob/src/server.cpp
24	It's a good practice to add where it listens and we have it in the `server_address`. Like `Server listening on 0.0.0.0:50051`. I think this message is useless without additional information. But I think this change can be in a follow-up diff.

This revision is now accepted and ready to land.Jul 21 2022, 2:01 PM

• karol added 1 blocking reviewer(s): tomek.Jul 21 2022, 2:38 PM

This revision now requires review to proceed.Jul 21 2022, 2:38 PM

tomek accepted this revision.Jul 22 2022, 10:32 AM

This revision is now accepted and ready to land.Jul 22 2022, 10:32 AM

• karol added inline comments.Jul 26 2022, 11:12 AM

services/blob/src/server.cpp
24	OK

• karol mentioned this in D4639: [services] Use mutual server listen address.Jul 26 2022, 11:26 AM

• karol added inline comments.

services/blob/src/server.cpp
24	D4639

This revision was landed with ongoing or failed builds.Jul 26 2022, 2:11 PM

Closed by commit rCOMMe955e113c436: [services] Blob - Remove couts or replace them with glog. · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMe955e113c436: [services] Blob - Remove couts or replace them with glog.

• karol mentioned this in rCOMM0dc8a1937bd6: [services] Use mutual server listen address.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

BlobServiceImpl.cpp

4 lines

6 lines

Diff 14761

services/blob/src/BlobServiceImpl.cpp

Loading...

services/blob/src/server.cpp

Loading...