Paths

Table of Contentst

-
nix/
1
dev-shell.nix

[NixOS] Allow for usage of Android NDK binaries
AbandonedPublic
Actions

Authored by • jon on Jul 21 2022, 12:36 PM.

Details

Reviewers

varun
ashoat

Summary

Android NDK distributes pre-compiled binaries which link against
libstdc++.so.6 and zlib. NixOS can't run them without some hacks, and
LD_LIBRARY_PATH is the quickest fix.

Test Plan

On NixOS, nix develop then build android

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 21 2022, 12:36 PM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 21 2022, 12:36 PM

Rebase to avoid CI breaking changes

Harbormaster failed remote builds in B10745: Diff 14785!Jul 21 2022, 12:41 PM

Re-order after tunnelbroker additions

Harbormaster completed remote builds in B10747: Diff 14787.Jul 21 2022, 12:52 PM

Accidental rebase mess up

Harbormaster completed remote builds in B10750: Diff 14790.Jul 21 2022, 1:02 PM

• jon mentioned this in D4483: [Nix] Support building Android through gradle on Linux.Jul 21 2022, 1:06 PM

Harbormaster completed remote builds in B10752: Diff 14792.Jul 21 2022, 1:15 PM

• jon requested review of this revision.Jul 21 2022, 1:15 PM

• jon added a parent revision: D4483: [Nix] Support building Android through gradle on Linux.Jul 21 2022, 1:20 PM

I don't really expect anyone to review this, setting up a NixOS machine is pretty niche, but it is helpful when doing android work on my desktop.

In D4602#131740, @jon wrote:

I don't really expect anyone to review this, setting up a NixOS machine is pretty niche, but it is helpful when doing android work on my desktop.

Do we want to land this diff?

This revision now requires changes to proceed.Jul 26 2022, 10:38 AM

I would like to land the diff. Should be a no-op on darwin.

• jon added a reviewer: ashoat.Jul 26 2022, 2:24 PM

I don't really expect anyone to review this, setting up a NixOS machine is pretty niche, but it is helpful when doing android work on my desktop.

This comment confused me, but I understand now that you meant you don't expect anyone to test this diff on their machine. Are we supporting NixOS for all development workflows or just Android?

Repeating my feedback from D4483:

In D4483#131125, @ashoat wrote:

Was chatting with @atul and neither of us is really sure what the product impact here is. The team (outside of @jon) doesn't use NixOS, so the only benefits I can see here are:

To improve @jon's personal custom workflow. Here, I wonder if we should be spending cycles supporting a custom niche use case, as opposed to having @jon use macOS primarily like the rest of the team

To provide an alternative to the CI build that we currently do with Debian. Here, it's not really clear if the change will be that impactful

At a high-level, I think we should be prioritizing Nix work that has an immediate impact on dev velocity and dev experience across all devs on the team. Until the whole team is actively using Nix for the primary development workflow, I'd prefer if we could deprioritize any other Nix work.

To help make the prioritization super clear, here are some clarificiations:

NixOS support should be deprioritized in favor of macOS Nix support

CI Nix support should be deprioritized in favor of dev environment Nix support

Nix as a replacement for Docker should be deprioritized in favor of Nix as a replacement for Homebrew and the dev environment instructions

I want to talk through the pattern of @jon using NixOS while trying to support the rest of the team (who are using Nix on macOS) in our 1:1 later today. We can follow-up on this diff after that.

This revision now requires changes to proceed.Jul 27 2022, 6:23 AM

Talked to @jon, we're going to avoid NixOS-specific diffs in favor of everyone on the team using Nix on Darwin for the near future

going to abandon for now, to clean up my queue

Revision Contents
Changeset List

Path

Size

nix/

dev-shell.nix

5 lines

Diff 14787

View Options

nix/dev-shell.nix

// @flow		// @flow

		import Icon from '@expo/vector-icons/FontAwesome5.js';
import { useNavigationState } from '@react-navigation/native';		import { useNavigationState } from '@react-navigation/native';
import invariant from 'invariant';		import invariant from 'invariant';
import * as React from 'react';		import * as React from 'react';
import { View } from 'react-native';		import { View, Text } from 'react-native';

import genesis from 'lib/facts/genesis.js';		import genesis from 'lib/facts/genesis.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';		import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import {		import {
userInfoSelectorForPotentialMembers,		userInfoSelectorForPotentialMembers,
userSearchIndexForPotentialMembers,		userSearchIndexForPotentialMembers,
} from 'lib/selectors/user-selectors.js';		} from 'lib/selectors/user-selectors.js';
import { getPotentialMemberItems } from 'lib/shared/search-utils.js';		import { getPotentialMemberItems } from 'lib/shared/search-utils.js';
▲ Show 20 Lines • Show All 189 Lines • ▼ Show 20 Lines	if (this.frozen) {
this.pendingListDataWithHeights = listDataWithHeights;		this.pendingListDataWithHeights = listDataWithHeights;
} else {		} else {
this.setState({ listDataWithHeights });		this.setState({ listDataWithHeights });
}		}
};		};
}		}

const unboundStyles = {		const unboundStyles = {
		pinnedCountBanner: {
		backgroundColor: 'panelForeground',
		height: 30,
		flexDirection: 'row',
		textAlign: 'center',
		justifyContent: 'center',
		alignItems: 'center',
		},
		pinnedCountText: {
		color: 'panelBackgroundLabel',
		marginRight: 5,
		},
container: {		container: {
backgroundColor: 'listBackground',		backgroundColor: 'listBackground',
flex: 1,		flex: 1,
},		},
threadContent: {		threadContent: {
flex: 1,		flex: 1,
},		},
hiddenThreadContent: {		hiddenThreadContent: {
▲ Show 20 Lines • Show All 124 Lines • ▼ Show 20 Lines	) {
const styles = useStyles(unboundStyles);		const styles = useStyles(unboundStyles);
const overlayContext = React.useContext(OverlayContext);		const overlayContext = React.useContext(OverlayContext);
const measureMessages = useHeightMeasurer();		const measureMessages = useHeightMeasurer();

const genesisThreadInfo = useSelector(		const genesisThreadInfo = useSelector(
state => threadInfoSelector(state)[genesis.id],		state => threadInfoSelector(state)[genesis.id],
);		);

		const bannerText = React.useMemo(() => {
		if (!threadInfo.pinnedCount \|\| threadInfo.pinnedCount === 0) {
		return '';
		}

		const messageNoun = threadInfo.pinnedCount === 1 ? 'message' : 'messages';
		return `${threadInfo.pinnedCount} pinned ${messageNoun}`;
		}, [threadInfo.pinnedCount]);
		atulUnsubmitted Not Done Inline Actions You don't need to use `React.useMemo(...)` here. The `useMemo()` hook is helpful for maintaining referential equality so that objects will be considered "shallowly equal" (`==` in JS) and we can avoid re-renders. This is helpful for objects (including `Map()`, `Set()`, etc), arrays (which are objects), and functions (which are objects). On the other hand, `string`s in JS are considered shallowly equal if they have the same contents, so we don't have to worry about re-renders if the "content" stays the same. See below: (In like C++, which you've been working w/ recently, `std::string`s can be allocated on the heap (unlike integers, booleans, etc) which may have been part of your reasoning that shallow equality would check reference instead of contents?) atul: You don't need to use `React.useMemo(...)` here. The `useMemo()` hook is helpful for…

		const pinnedCountBanner = React.useMemo(() => {
		if (!bannerText) {
		return null;
		}

		return (
		<View style={styles.pinnedCountBanner}>
		<Text style={styles.pinnedCountText}>{bannerText}</Text>
		<Icon
		name="chevron-right"
		size={12}
		color={colors.panelBackgroundLabel}
		/>
		</View>
		);
		}, [
		bannerText,
		styles.pinnedCountBanner,
		styles.pinnedCountText,
		colors.panelBackgroundLabel,
		]);

return (		return (
<MessageListContextProvider threadInfo={threadInfo}>		<MessageListContextProvider threadInfo={threadInfo}>
		{pinnedCountBanner}
<MessageListContainer		<MessageListContainer
{...props}		{...props}
usernameInputText={usernameInputText}		usernameInputText={usernameInputText}
updateUsernameInput={updateUsernameInput}		updateUsernameInput={updateUsernameInput}
userInfoInputArray={userInfoInputArray}		userInfoInputArray={userInfoInputArray}
updateTagInput={updateTagInput}		updateTagInput={updateTagInput}
resolveToUser={resolveToUser}		resolveToUser={resolveToUser}
otherUserInfos={otherUserInfos}		otherUserInfos={otherUserInfos}
Show All 14 Lines

[NixOS] Allow for usage of Android NDK binariesAbandonedPublicActions