Paths

Table of Contentst

Differential D4632

[services] Tests - Backup - Add attachments for backups
ClosedPublic
Actions

Authored by • karol on Jul 26 2022, 2:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 6, 12:37 PM

	Unknown Object (File)
	Sat, Jul 6, 12:37 PM

	Unknown Object (File)
	Sat, Jul 6, 12:37 PM

	Unknown Object (File)
	Sat, Jul 6, 12:37 PM

	Unknown Object (File)
	Sat, Jul 6, 12:37 PM

	Unknown Object (File)
	Sat, Jul 6, 12:37 PM

	Unknown Object (File)
	Fri, Jul 5, 10:07 PM

	Unknown Object (File)
	Thu, Jul 4, 10:35 AM

Subscribers

Details

Reviewers

tomek
varun

Commits

rCOMM0971023d31cb: [services] Tests - Backup - Add attachments for backups

Summary

Depends on D4637

Adding a piece of test for "add attachments for backup" functionality.

Test Plan

cd services
yarn run-performance-tests backup 1

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jul 26 2022, 2:34 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 26 2022, 2:34 AM

• karol edited the summary of this revision. (Show Details)Jul 26 2022, 2:44 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun.

• karol added a parent revision: D4631: [services] Tests - Backup - Initialize performance tests.

• karol added a child revision: D4633: [services] Tests - Backup - Send log.

• karol added inline comments.

services/commtest/tests/backup_performance_test.rs
95 ↗	(On Diff #14924)	This should go in a previous diff

Harbormaster completed remote builds in B10861: Diff 14924.Jul 26 2022, 2:48 AM

• karol requested review of this revision.Jul 26 2022, 2:48 AM

• karol edited the summary of this revision. (Show Details)Jul 26 2022, 2:53 AM

• karol added a parent revision: D4637: [services] Tests - Backup - Create new backup.

• karol removed a parent revision: D4631: [services] Tests - Backup - Initialize performance tests.

tomek accepted this revision.Jul 26 2022, 5:20 AM

tomek added inline comments.

services/commtest/tests/backup_performance_test.rs
95 ↗	(On Diff #14924)	Are you going to move it to the previous diff?
108 ↗	(On Diff #14924)	When we're not using index, we can simply iterate without using enumeration
112–117 ↗	(On Diff #14924)	I don't think early exit is beneficial in this case. The "else" is just a single instruction, so maybe put it in `if` then?

This revision is now accepted and ready to land.Jul 26 2022, 5:20 AM

• karol added inline comments.Jul 26 2022, 7:06 AM

services/commtest/tests/backup_performance_test.rs
95 ↗	(On Diff #14924)	yes, the change's coming
112–117 ↗	(On Diff #14924)	ok

address feedback

Harbormaster completed remote builds in B10891: Diff 14969.Jul 26 2022, 7:19 AM

rebase

Harbormaster completed remote builds in B10947: Diff 15057.Jul 28 2022, 6:40 AM

Closed by commit rCOMM0971023d31cb: [services] Tests - Backup - Add attachments for backups (authored by • karol). · Explain WhyAug 2 2022, 3:02 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM0971023d31cb: [services] Tests - Backup - Add attachments for backups.

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

backup_performance_test.rs

23 lines

Diff 15057

services/commtest/tests/backup_performance_test.rs

Loading...