Depends on D4637
Adding a piece of test for "add attachments for backup" functionality.
Details
Details
cd services yarn run-performance-tests backup 1
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/commtest/tests/backup_performance_test.rs | ||
|---|---|---|
| 95 ↗ | (On Diff #14924) | This should go in a previous diff |
| services/commtest/tests/backup_performance_test.rs | ||
|---|---|---|
| 95 ↗ | (On Diff #14924) | Are you going to move it to the previous diff? |
| 108 ↗ | (On Diff #14924) | When we're not using index, we can simply iterate without using enumeration |
| 112–117 ↗ | (On Diff #14924) | I don't think early exit is beneficial in this case. The "else" is just a single instruction, so maybe put it in if then? |