[services] Use mutual server listen address
ClosedPublic
Actions

Authored by • karol on Jul 26 2022, 11:24 AM.

Details

Reviewers

tomek
• max

Commits

rCOMM0dc8a1937bd6: [services] Use mutual server listen address

Summary

Depends on D4595

This is a follow-up for https://phab.comm.dev/D4590#131582

Test Plan

Services build properly (tunnelbroker, blob, backup)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Jul 26 2022, 11:24 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 26 2022, 11:24 AM

• karol edited the summary of this revision. (Show Details)Jul 26 2022, 11:26 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D4595: [services] Lib - remove include iostream.

• karol edited the test plan for this revision. (Show Details)

• karol mentioned this in D4590: [services] Blob - Remove couts or replace them with glog.

No need to wait for the mobile builds

Harbormaster completed remote builds in B10875: Diff 14952.Jul 26 2022, 11:34 AM

tomek accepted this revision.Jul 26 2022, 2:01 PM

This revision is now accepted and ready to land.Jul 26 2022, 2:01 PM

Closed by commit rCOMM0dc8a1937bd6: [services] Use mutual server listen address. · Explain WhyJul 26 2022, 2:11 PM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM0dc8a1937bd6: [services] Use mutual server listen address.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

server.cpp

8 lines

blob/

src/

server.cpp

8 lines

lib/

src/

GlobalConstants.h

3 lines

tunnelbroker/

src/

Constants.h

3 lines

server.cpp

4 lines

Diff 14978

View Options

services/backup/src/server.cpp

View Options

services/blob/src/server.cpp

View Options

services/lib/src/GlobalConstants.h

View Options

services/tunnelbroker/src/Constants.h

View Options

services/tunnelbroker/src/server.cpp

[services] Use mutual server listen addressClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14978

services/backup/src/server.cpp

services/blob/src/server.cpp

services/lib/src/GlobalConstants.h

services/tunnelbroker/src/Constants.h

services/tunnelbroker/src/server.cpp

[services] Use mutual server listen address
ClosedPublic
Actions

Revision Contents
Changeset List