I'm switching from looping through responses from the Identity service to having separate response handlers for each response type.
Depends on D4854
Details
Details
cargo build. this helper will be tested in a diff later in the stack that uses it
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs | ||
|---|---|---|
| 207 ↗ | (On Diff #15697) | Shouldn't we take this by reference? |
| 214–236 ↗ | (On Diff #15697) | Not sure if naming or logic is wrong, but something confusing is happening here. We start with pake_registration_finish, then we call pake_login_start and assign the result to client_registration_start_result and then create registration_request and send it through tx.
Maybe this is correct, but I'm confused now. |
| native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs | ||
|---|---|---|
| 207 ↗ | (On Diff #15697) | It's cheap to clone the Sender, because it's essentially a reference count increment |
| 214–236 ↗ | (On Diff #15697) | Ah, yeah client_registration_start_result should be client_login_start_result. RegistrationRequest in this context refers to the gRPC message struct, not the PAKE one. I know this is confusing, but I'm not sure what would make it clearer. |
| native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs | ||
|---|---|---|
| 214–236 ↗ | (On Diff #15697) | Ok, makes sense! I think that it might be a good idea to have a code comment explaining that. |