This helper function checks that the message is what we expect, and then completes PAKE login and returns a message to the Identity service.
Depends on D4855
Paths
| Differential D4856 Authored by varun on Aug 16 2022, 8:27 PM.
Details Summary This helper function checks that the message is what we expect, and then completes PAKE login and returns a message to the Identity service. Depends on D4855 Test Plan cargo build. this will be tested later by the function that uses the helper
Diff Detail
Event TimelineHerald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptAug 16 2022, 8:27 PM2022-08-16 20:27:09 (UTC-7) Harbormaster completed remote builds in B11409: Diff 15698.Aug 16 2022, 8:37 PM2022-08-16 20:37:25 (UTC-7) This revision is now accepted and ready to land.Aug 17 2022, 6:53 AM2022-08-17 06:53:45 (UTC-7) Closed by commit rCOMM00846ff97359: [native] helper to handle credential response from Identity service (authored by varun). · Explain WhyAug 18 2022, 11:34 AM2022-08-18 11:34:03 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 15751 native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs
|
Do we really want to make this change in production? Should we consider gating it on isStaffRelease?