Page MenuHomePhabricator

[services] Add curl to the base image
ClosedPublic

Authored by karol on Aug 17 2022, 3:53 AM.
Tags
None
Referenced Files
F2055503: D4859.diff
Thu, Jun 20, 8:06 AM
Unknown Object (File)
Tue, Jun 18, 11:28 AM
Unknown Object (File)
Tue, Jun 18, 11:28 AM
Unknown Object (File)
Sat, Jun 15, 1:04 AM
Unknown Object (File)
Wed, Jun 12, 9:06 PM
Unknown Object (File)
Mon, Jun 10, 4:15 AM
Unknown Object (File)
Sun, May 26, 11:52 AM
Unknown Object (File)
May 2 2024, 2:30 PM

Details

Summary

Depends on D4858

I added curl to the base image since it is needed to install rust.

The reason I didn't add rust right away to the base image is that we'll be using rust in the backup and tunnelbroker which makes it redundant in the blob service.

Test Plan

services build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 17 2022, 9:13 AM
This revision now requires review to proceed.Aug 18 2022, 4:11 AM

Nice, so we can move Rust install from the backup / Tunnelbroker images since we can just do it in the base image now, right?

As I said in the description

The reason I didn't add rust right away to the base image is that we'll be using rust in the backup and tunnelbroker which makes it redundant in the blob service.

So if we're okay with having rust in blob even though we do not use it there then I can move it (rust installation) up to the base image.

Ah, I see... we're planning to continue using gRPC C++ Reactors in blob for now, since it doesn't have the same problems. I think it would be good to eventually move that one over as well, but it makes sense to sequence it later

This revision is now accepted and ready to land.Aug 18 2022, 10:37 AM
This revision was automatically updated to reflect the committed changes.