Depends on D4858
I added curl to the base image since it is needed to install rust.
The reason I didn't add rust right away to the base image is that we'll be using rust in the backup and tunnelbroker which makes it redundant in the blob service.
Paths
| Differential D4859 Authored by • karol on Aug 17 2022, 3:53 AM.
Tags None Referenced Files
Details
Summary Depends on D4858 I added curl to the base image since it is needed to install rust. The reason I didn't add rust right away to the base image is that we'll be using rust in the backup and tunnelbroker which makes it redundant in the blob service. Test Plan services build
Diff Detail
Event TimelineHerald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptAug 17 2022, 3:53 AM2022-08-17 03:53:34 (UTC-7) • karol edited the summary of this revision. (Show Details)Aug 17 2022, 3:59 AM2022-08-17 03:59:49 (UTC-7) • karol added a child revision: D4860: [services] Tunnelbroker - Move install corrosion script to lib. Harbormaster completed remote builds in B11413: Diff 15702.Aug 17 2022, 4:03 AM2022-08-17 04:03:47 (UTC-7) This revision is now accepted and ready to land.Aug 17 2022, 9:13 AM2022-08-17 09:13:15 (UTC-7) This revision now requires review to proceed.Aug 18 2022, 4:11 AM2022-08-18 04:11:21 (UTC-7) Comment Actions Nice, so we can move Rust install from the backup / Tunnelbroker images since we can just do it in the base image now, right? Comment Actions As I said in the description
So if we're okay with having rust in blob even though we do not use it there then I can move it (rust installation) up to the base image. Comment Actions Ah, I see... we're planning to continue using gRPC C++ Reactors in blob for now, since it doesn't have the same problems. I think it would be good to eventually move that one over as well, but it makes sense to sequence it later This revision is now accepted and ready to land.Aug 18 2022, 10:37 AM2022-08-18 10:37:56 (UTC-7) Closed by commit rCOMM14efcd6e0c83: [services] Add curl to the base image (authored by • karol). · Explain WhyAug 24 2022, 8:13 AM2022-08-24 08:13:47 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 15931 services/backup/Dockerfile
services/base-image/Dockerfile
services/blob/Dockerfile
services/scripts/build_base_image.sh
services/tunnelbroker/Dockerfile
|