Depends on D4888
I added the code that compiles proto files. We need to compile the blob proto file in order to write a client that will communicate with the service.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/backup/blob_client/build.rs | ||
|---|---|---|
| 9–13 ↗ | (On Diff #15791) | I did it this way so we can launch it in the docker container but also do the cargo check (which is very useful as the output looks great and it works fast) |
Comment Actions
(Setting people as blocking so that the diff appears on their queues, but don't think they all necessary need to review)
Comment Actions
Looks ok but it is a really good idea for @varun to also take a look
| services/backup/blob_client/Cargo.toml | ||
|---|---|---|
| 19 ↗ | (On Diff #15791) | |
| services/backup/blob_client/build.rs | ||
| 9–13 ↗ | (On Diff #15791) | It is beneficial to avoid mutability where we can. Also, it might be a good idea to create a variable with ¤t_dir().unwrap().into_os_string().into_string().unwrap() so the expression is more readable. |
Comment Actions
I would like to get rid of docker vs non-docker logic, but I will tackle that in https://linear.app/comm/issue/ENG-1231
LGTM otherwise
Not related to diff, but I find it hilarious that there's a NixOS section for tonic: https://docs.rs/tonic-build/latest/tonic_build/#nixos-related-hints
| services/backup/blob_client/build.rs | ||
|---|---|---|
| 2 ↗ | (On Diff #15791) | where is this used? |