Page MenuHomePhabricator
Differential D4884

[services] Backup - Rust lib - Add is initialized
ClosedPublic
Actions

Authored by • karol on Aug 19 2022, 1:28 AM.
Tags
None
Referenced Files
F5887643: D4884.id15978.diff
Thu, Apr 17, 4:36 AM
Unknown Object (File)
Wed, Mar 19, 7:30 PM
Unknown Object (File)
Mar 18 2025, 1:38 PM
Unknown Object (File)
Mar 16 2025, 7:18 AM
Unknown Object (File)
Mar 16 2025, 7:18 AM
Unknown Object (File)
Mar 16 2025, 7:18 AM
Unknown Object (File)
Mar 16 2025, 7:18 AM
Unknown Object (File)
Mar 16 2025, 7:18 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
varun
tomek
ashoat
• jon
Commits
rCOMM15ddad8a5688: [services] Backup - Rust lib - Add is initialized
Summary

Depends on D4861

Adding a function that checks whether the client's been initialized

Test Plan

test plan in D4870

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Aug 19 2022, 1:28 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptAug 19 2022, 1:28 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 19 2022, 1:29 AM
Harbormaster failed remote builds in B11468: Diff 15779!
• karol edited the summary of this revision. (Show Details)Aug 19 2022, 1:32 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: varun, tomek.
• karol added a parent revision: D4861: [services] Backup - Add Rust.
• karol added a child revision: D4867: [services] Backup - Rust lib - Add initialize.
• karol requested review of this revision.Aug 19 2022, 1:43 AM
tomek accepted this revision.Aug 19 2022, 7:31 AM
tomek added a reviewer: ashoat. tomek added 1 blocking reviewer(s): varun.

Adding @ashoat because there are new dependencies.

services/backup/rust_lib/Cargo.toml
8 ↗(On Diff #15779)

Why do we use 1.0 when 1.20 is available? I think in some diff it was agreed that we should specify major and minor versions.

9–11 ↗(On Diff #15779)

In one diff it was agreed that we should specify major and minor versions. @varun am I right?

services/backup/rust_lib/src/lib.rs
16 ↗(On Diff #15779)

We should avoid using legacy syntax and instead use use.

ashoat accepted this revision.Aug 20 2022, 8:51 AM

Dependencies seem reasonable, but curious about @tomek's versioning questions above

varun accepted this revision.Aug 22 2022, 8:55 AM
varun added inline comments.
services/backup/rust_lib/Cargo.toml
9–11 ↗(On Diff #15779)

yeah we should omit the patch version

services/backup/rust_lib/src/lib.rs
33–38 ↗(On Diff #15779)

can just combine these with an "or" operator, right?

This revision is now accepted and ready to land.Aug 22 2022, 8:55 AM
• karol updated this revision to Diff 15926.Aug 24 2022, 6:40 AM

ci

Harbormaster completed remote builds in B11584: Diff 15926.Aug 24 2022, 6:50 AM
• karol added inline comments.Aug 25 2022, 3:29 AM
services/backup/rust_lib/Cargo.toml
8 ↗(On Diff #15779)

ok, we can change to 1.20

9–11 ↗(On Diff #15779)

ok

services/backup/rust_lib/src/lib.rs
16 ↗(On Diff #15779)

ok

33–38 ↗(On Diff #15779)

We can do this super simple thing in many more ways, I don't think that matters, really.

• karol updated this revision to Diff 15965.Aug 25 2022, 3:32 AM

address comments

Harbormaster completed remote builds in B11607: Diff 15965.Aug 25 2022, 3:42 AM
• karol updated this revision to Diff 15978.Aug 25 2022, 5:12 AM

run cargo fmt

Harbormaster completed remote builds in B11615: Diff 15978.Aug 25 2022, 5:22 AM
tomek requested changes to this revision.Aug 25 2022, 9:58 AM

Something (probably rebase) went wrong with this diff. An update with run cargo fmt description introduced a lot of new code.

This revision now requires changes to proceed.Aug 25 2022, 9:58 AM
• karol updated this revision to Diff 15994.Aug 26 2022, 1:29 AM

update

Harbormaster completed remote builds in B11628: Diff 15994.Aug 26 2022, 1:39 AM
tomek accepted this revision.Aug 26 2022, 1:50 AM
This revision is now accepted and ready to land.Aug 26 2022, 1:50 AM
Closed by commit rCOMM15ddad8a5688: [services] Backup - Rust lib - Add is initialized (authored by • karol). · Explain WhyAug 29 2022, 7:02 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM15ddad8a5688: [services] Backup - Rust lib - Add is initialized.
Herald added a reviewer: • jon. · View Herald TranscriptAug 29 2022, 7:02 AM

Revision Contents
Changeset List

PathSize
1 line
services/
backup/
rust_lib/
4 lines
src/
1 line
48 lines

Diff 16064

View Options

.gitignore

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

services/backup/rust_lib/Cargo.lock

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

services/backup/rust_lib/Cargo.toml

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

services/backup/rust_lib/src/constants.rs

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

services/backup/rust_lib/src/lib.rs

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };