Page MenuHomePhabricator
Differential D4860

[services] Tunnelbroker - Move install corrosion script to lib
ClosedPublic
Actions

Authored by • karol on Aug 17 2022, 3:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 18, 11:28 AM
Unknown Object (File)
Tue, Jun 18, 11:28 AM
Unknown Object (File)
Tue, Jun 18, 11:28 AM
Unknown Object (File)
May 2 2024, 2:30 PM
Unknown Object (File)
Apr 30 2024, 6:21 PM
Unknown Object (File)
Apr 30 2024, 6:21 PM
Unknown Object (File)
Apr 29 2024, 5:48 PM
Unknown Object (File)
Apr 29 2024, 5:48 PM
View All 73 Files
Subscribers
• abosh
• adrian
ashoat
atul
• jon
tomek

Details

Reviewers
tomek
• max
• jon
Commits
rCOMMbed184d6e34b: [services] Tunnelbroker - Move install corrosion script to lib
Summary

Depends on D4859

I will be using corrosion in the backup service so I moved the script to install it to the mutual space: lib.

Test Plan

tunnelbroker still builds

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Aug 17 2022, 3:53 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptAug 17 2022, 3:53 AM
• karol edited the summary of this revision. (Show Details)Aug 17 2022, 4:00 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D4859: [services] Add curl to the base image.
Harbormaster completed remote builds in B11414: Diff 15703.Aug 17 2022, 4:03 AM
• karol requested review of this revision.Aug 17 2022, 4:03 AM
• max accepted this revision.Aug 17 2022, 4:10 AM

This diff shouldn't depend on D4859 and D4858. Seems that it's independent and the Tunnelbroker is successfully built without the parent diffs.

This revision is now accepted and ready to land.Aug 17 2022, 4:10 AM
• karol added a child revision: D4861: [services] Backup - Add Rust.Aug 17 2022, 4:11 AM
• karol added 1 blocking reviewer(s): tomek.Aug 18 2022, 4:11 AM
This revision now requires review to proceed.Aug 18 2022, 4:11 AM
ashoat added a reviewer: • jon.Aug 18 2022, 6:48 AM
ashoat added a subscriber: • jon.

Adding @jon since I know he's been looking at these "install" bash scripts

• jon accepted this revision.EditedAug 18 2022, 7:46 AM

if it's going to be used in more than once service, I think this makes sense.

I think it would make even more sense to just have all of the scripts in a single directory for services as they are more of a concern of docker than any service, but that's out of scope.

tomek accepted this revision.Aug 18 2022, 10:36 AM
This revision is now accepted and ready to land.Aug 18 2022, 10:36 AM
• karol updated this revision to Diff 15932.Aug 24 2022, 8:16 AM
• karol edited the summary of this revision. (Show Details)

rebase

This revision was landed with ongoing or failed builds.Aug 24 2022, 8:16 AM
Closed by commit rCOMMbed184d6e34b: [services] Tunnelbroker - Move install corrosion script to lib (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMbed184d6e34b: [services] Tunnelbroker - Move install corrosion script to lib.
Harbormaster completed remote builds in B11588: Diff 15932.Aug 24 2022, 8:26 AM

Revision Contents
Changeset List

PathSize
services/
lib/
docker/
tunnelbroker/
docker/
tunnelbroker/
2 lines
docker/

Diff 15933

View Options

services/lib/docker/install_corrosion.sh

Loading...
View Options

services/tunnelbroker/Dockerfile

Loading...
View Options

services/tunnelbroker/docker/install_corrosion.sh

Loading...