Details

Reviewers

tomek
varun
• jon
ashoat

Summary

This differential initializes directory with rust library to exchange data with blob service in a way suitable for mobile devices. Cargo.toml is the only file that actually matters here.

Test Plan

Run cargo build from project root

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Sep 5 2022, 7:36 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 5 2022, 7:36 AM

Herald added subscribers: • abosh, atul, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B11887: Diff 16328.Sep 5 2022, 7:46 AM

marcin requested review of this revision.Sep 5 2022, 7:46 AM

tomek accepted this revision.Sep 5 2022, 8:31 AM

tomek added inline comments.

native/cpp/CommonCpp/grpc/blob_client/rust/Cargo.toml
10 ↗	(On Diff #16328)	We should provide major and minor version. Do we use all the provided features?
22 ↗	(On Diff #16328)	Please add a new line

This revision is now accepted and ready to land.Sep 5 2022, 8:31 AM

marcin added a child revision: D5052: Expose module with generated tonic blob client code.Sep 5 2022, 11:52 AM

marcin added inline comments.Sep 7 2022, 4:42 AM

native/cpp/CommonCpp/grpc/blob_client/rust/Cargo.toml
10 ↗	(On Diff #16328)	You were right, in further diffs I do not need "macros", but the way I initialize runtime (@varun does it the same way) requires "rt-multi-thread"

Update dependencies

newline

Harbormaster completed remote builds in B11954: Diff 16406.Sep 7 2022, 8:30 AM

Harbormaster completed remote builds in B11955: Diff 16407.Sep 7 2022, 8:32 AM

Adding @ashoat because there are new dependencies

This revision now requires review to proceed.Sep 9 2022, 6:30 AM

In D5051#148862, @tomek wrote:

Adding @ashoat because there are new dependencies

All dependencies here are already in grpc_client/Cargo.toml from current master. Most probably entire blob client code will be merged into grpc_client as rust module.

• jon requested changes to this revision.Sep 12 2022, 9:19 AM

• jon added inline comments.

native/cpp/CommonCpp/grpc/blob_client/rust/Cargo.toml
2 ↗	(On Diff #16407)	should give it a more appropriate name

This revision now requires changes to proceed.Sep 12 2022, 9:19 AM

I created this revision when I thought my blob client will be a separate binary. But since we agreed on creating one Rust crate for all native gRPC code, this revision will be abandoned once @varun refactors grpc_client. My blob client uses the same dependencies that are already used inside grpc_client so this revision will not be necessary. I do not think it is worth any reviewer time to review this.