This differential generates Rust bindings for blob API.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/grpc/blob_client/rust/build.rs | ||
|---|---|---|
| 5 ↗ | (On Diff #16329) | Once I rebase the stack this line should disappear, but I will reply here. I was unable to compile C++ code calling rust functions implemented further in this stack, when I was using c++11, so I bumped it to c++14 and it worked. I didn't investigate it further since we already use C++14 on native (see CMakeLists.txt in android for instance). But if it it needed I can check why we need c++14 here. |
| native/cpp/CommonCpp/grpc/blob_client/rust/src/lib.rs | ||
| 4 ↗ | (On Diff #16329) | Sure. |
| native/cpp/CommonCpp/grpc/blob_client/rust/build.rs | ||
|---|---|---|
| 5 ↗ | (On Diff #16329) | There are some places where we're using C++17, and some other where migrating to 17 was an issue. Probably native was one of them and we should keep 14 for now. |
| native/cpp/CommonCpp/grpc/blob_client/rust/build.rs | ||
|---|---|---|
| 5 ↗ | (On Diff #16329) | The generated code should be C++11 + extensions. So C++14 and beyond should work fine. C++14 vs C++17 shouldn't be much of an issue, as all the compilers we use should support at least C++17. |