[services] Tunnelbroker - Adding of Tonic crate to cargo dependencies
ClosedPublic
Actions

Authored by • max on Sep 29 2022, 8:18 AM.

Details

Reviewers

• jon
tomek
varun

Commits

rCOMM17f6455b8006: [services] Tunnelbroker - Adding of Tonic crate to cargo dependencies

Summary

This diff introduces adding the Tonic to cargo dependencies for the Rust library in Tunnelbroker.
The purpose of adding Tonic is to use it for gRPC communication.

Related Linear task: ENG-1072

Test Plan

No test plan, this is just a dependency.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Sep 29 2022, 8:18 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 29 2022, 8:18 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max published this revision for review.Sep 29 2022, 8:21 AM

• max retitled this revision from [services] Tunnelbroker - Adding Tonic to crate dependencies to [services] Tunnelbroker - Adding of Tonic crate to cargo dependencies.

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: tomek. • max added 1 blocking reviewer(s): • jon.

• max added a parent revision: D5261: [services] Tunnelbroker - Renaming Rust library directory from `rust-notifications` to `rust-lib`.

Harbormaster completed remote builds in B12531: Diff 17195.Sep 29 2022, 8:29 AM

ashoat added a reviewer: varun.Sep 29 2022, 9:20 AM

There are two different versions of the lib used in our project 0.8 and 0.6. We should try to keep them in sync, so it might be a good idea to upgrade the older ones at some point.

• jon accepted this revision.Sep 29 2022, 9:33 AM

This revision is now accepted and ready to land.Sep 29 2022, 9:33 AM

@max, before landing can you create a task to unify tonic version across the project and link it here?

In D5265#155167, @ashoat wrote:

@max, before landing can you create a task to unify tonic version across the project and link it here?

Yes, sure!

In D5265#155121, @tomek wrote:

There are two different versions of the lib used in our project 0.8 and 0.6. We should try to keep them in sync, so it might be a good idea to upgrade the older ones at some point.

Yes, this is a good point, I'll create a task and put up a diff for that (that's pretty small changes).