Details

Reviewers

• jon
michal
marcin
varun
tomek

Commits

rCOMM1880c350abb9: [services] Tunnelbroker - Renaming Rust library directory from `rust…

Summary

This diff renaming the Rust code directory from rust-notifications to rust-lib name, because we are going to use a single Rust library with the submodules instead of building separate Rust libraries.

This is a part of the stack.
The full context is available in the Linear task.

Related Linear task: ENG-1895

Test Plan

Service is successfully built and the Rust function is successfully called from the C++ side.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Sep 29 2022, 4:56 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 29 2022, 4:56 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5250: [services] Tunnelbroker - Move Rust notifications library code to the submodule.Sep 29 2022, 4:57 AM

Harbormaster failed remote builds in B12519: Diff 17180!Sep 29 2022, 4:58 AM

Fixing C++ import path.

Harbormaster completed remote builds in B12521: Diff 17182.Sep 29 2022, 5:21 AM

• max added a child revision: D5262: [services] Tunnelbroker - Changes to use `bail` and `ensure` Anyhow macros.Sep 29 2022, 5:37 AM

Updating .gitignore file with the new directory name.

Harbormaster completed remote builds in B12523: Diff 17185.Sep 29 2022, 5:48 AM

• max published this revision for review.Sep 29 2022, 6:03 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: michal, tomek.

tomek edited reviewers, added: marcin; removed: tomek.Sep 29 2022, 7:07 AM

• max added a child revision: D5263: [services] Tunnelbroker - Using `rust::notifications` namespace for calling Rust from C++.Sep 29 2022, 7:38 AM

• max added a child revision: D5265: [services] Tunnelbroker - Adding of Tonic crate to cargo dependencies.Sep 29 2022, 8:22 AM

ashoat added a reviewer: varun.Sep 29 2022, 9:13 AM

• jon accepted this revision.Sep 29 2022, 9:42 AM

marcin accepted this revision.Sep 30 2022, 1:10 AM

marcin added a reviewer: tomek.

tomek accepted this revision.Sep 30 2022, 6:14 AM

This revision is now accepted and ready to land.Sep 30 2022, 6:14 AM

Rebased on master changes.

Harbormaster completed remote builds in B12559: Diff 17242.Sep 30 2022, 7:01 AM

Closed by commit rCOMM1880c350abb9: [services] Tunnelbroker - Renaming Rust library directory from `rust… (authored by • max). · Explain WhySep 30 2022, 7:01 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM1880c350abb9: [services] Tunnelbroker - Renaming Rust library directory from `rust….

[services] Tunnelbroker - Renaming Rust library directory from `rust-notifications` to `rust-lib`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 17245

.gitignore

services/tunnelbroker/CMakeLists.txt

services/tunnelbroker/rust-lib/Cargo.lock

services/tunnelbroker/rust-lib/Cargo.toml

services/tunnelbroker/rust-lib/build.rs

services/tunnelbroker/rust-lib/src/lib.rs

services/tunnelbroker/rust-lib/src/notifications/apns.rs

services/tunnelbroker/rust-lib/src/notifications/fcm.rs

services/tunnelbroker/rust-lib/src/notifications/mod.rs

services/tunnelbroker/rust-notifications/Cargo.lock

services/tunnelbroker/rust-notifications/Cargo.toml

services/tunnelbroker/rust-notifications/build.rs

services/tunnelbroker/rust-notifications/src/lib.rs

services/tunnelbroker/rust-notifications/src/notifications/apns.rs

services/tunnelbroker/rust-notifications/src/notifications/fcm.rs

services/tunnelbroker/rust-notifications/src/notifications/mod.rs

services/tunnelbroker/src/Service/TunnelbrokerServiceImpl.cpp

[services] Tunnelbroker - Renaming Rust library directory from `rust-notifications` to `rust-lib`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17245

.gitignore

services/tunnelbroker/CMakeLists.txt

services/tunnelbroker/rust-lib/Cargo.lock

services/tunnelbroker/rust-lib/Cargo.toml

services/tunnelbroker/rust-lib/build.rs

services/tunnelbroker/rust-lib/src/lib.rs

services/tunnelbroker/rust-lib/src/notifications/apns.rs

services/tunnelbroker/rust-lib/src/notifications/fcm.rs

services/tunnelbroker/rust-lib/src/notifications/mod.rs

services/tunnelbroker/rust-notifications/Cargo.lock

services/tunnelbroker/rust-notifications/Cargo.toml

services/tunnelbroker/rust-notifications/build.rs

services/tunnelbroker/rust-notifications/src/lib.rs

services/tunnelbroker/rust-notifications/src/notifications/apns.rs

services/tunnelbroker/rust-notifications/src/notifications/fcm.rs

services/tunnelbroker/rust-notifications/src/notifications/mod.rs

services/tunnelbroker/src/Service/TunnelbrokerServiceImpl.cpp

[services] Tunnelbroker - Renaming Rust library directory from `rust-notifications` to `rust-lib`
ClosedPublic
Actions

Revision Contents
Changeset List