Page MenuHomePhabricator
Differential D5250

[services] Tunnelbroker - Move Rust notifications library code to the submodule
ClosedPublic
Actions

Authored by • max on Sep 28 2022, 11:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 9:32 AM
Unknown Object (File)
Tue, Nov 5, 9:32 AM
Unknown Object (File)
Tue, Nov 5, 9:32 AM
Unknown Object (File)
Tue, Nov 5, 9:28 AM
Unknown Object (File)
Sat, Oct 19, 7:52 PM
Unknown Object (File)
Oct 10 2024, 5:09 PM
Unknown Object (File)
Oct 6 2024, 6:24 AM
Unknown Object (File)
Sep 13 2024, 2:23 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
michal
marcin
varun
tomek
Commits
rCOMM83c281dc6c74: [services] Tunnelbroker - Move Rust notifications library code to the submodule
Summary

This diff moves the Rust notifications code into the notifications submodule as a part of the transition to using a single Rust library linked to the C++ codebase.

This is a part of the stack.
The full context is available in the Linear task.

Related Linear task: ENG-1895

Test Plan

Service is successfully built and the Rust function is successfully called from the C++ side.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Sep 28 2022, 11:12 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 28 2022, 11:12 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B12498: Diff 17153.Sep 28 2022, 11:23 AM
• max added a child revision: D5261: [services] Tunnelbroker - Renaming Rust library directory from `rust-notifications` to `rust-lib`.Sep 29 2022, 4:57 AM
• max edited the summary of this revision. (Show Details)Sep 29 2022, 6:00 AM
• max edited the test plan for this revision. (Show Details)
• max added reviewers: michal, tomek.
• max published this revision for review.Sep 29 2022, 6:03 AM
tomek edited reviewers, added: marcin; removed: tomek.Sep 29 2022, 7:07 AM
ashoat added a reviewer: varun.Sep 29 2022, 9:13 AM
• jon accepted this revision.Sep 29 2022, 9:42 AM
marcin accepted this revision.Sep 30 2022, 1:06 AM
marcin added a reviewer: tomek.
tomek accepted this revision.Sep 30 2022, 6:12 AM
This revision is now accepted and ready to land.Sep 30 2022, 6:12 AM
Closed by commit rCOMM83c281dc6c74: [services] Tunnelbroker - Move Rust notifications library code to the submodule (authored by • max). · Explain WhySep 30 2022, 6:50 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM83c281dc6c74: [services] Tunnelbroker - Move Rust notifications library code to the submodule.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
rust-notifications/
src/
7 lines
notifications/
notifications/
2 lines

Diff 17241

View Options

services/tunnelbroker/rust-notifications/src/apns.rs

Loading...
View Options

services/tunnelbroker/rust-notifications/src/fcm.rs

Loading...
View Options

services/tunnelbroker/rust-notifications/src/lib.rs

Loading...
View Options

services/tunnelbroker/rust-notifications/src/notifications/apns.rs

Loading...
View Options

services/tunnelbroker/rust-notifications/src/notifications/fcm.rs

Loading...
View Options

services/tunnelbroker/rust-notifications/src/notifications/mod.rs

Loading...