[lib] Introduce `translateMediaToClientDBMediaInfos`
ClosedPublic
Actions

Authored by atul on Oct 4 2022, 6:52 PM.

Details

Reviewers

tomek
marcin
• abosh
rohan
ginsu

Commits

rCOMMe40c4596154a: [lib] Introduce `translateMediaToClientDBMediaInfos`

Summary

We previously had translateMediaToClientDBMediaInfo which gave us one ClientDBMediaInfo for each Media... but now the relationship between Media and "upload" is no longer 1:1.

translateMediaToClientDBMediaInfos replaces the existing function and returns an array with all of the ClientDBMediaInfos for a media message. By using this function in translateRawMessageInfoToClientDBMessageInfo we ensure that both the video and thumbnail are persisted in the media table of the SQLite "clientDB" database.

Test Plan

Ensured that both video and thumbnail are stored in SQLite media table for video messages:

Also set breakpoints throughout to make sure values at different points were as expected.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D5241_1 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Oct 4 2022, 6:52 PM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 4 2022, 6:52 PM

atul edited the test plan for this revision. (Show Details)Oct 4 2022, 6:56 PM

Harbormaster completed remote builds in B12608: Diff 17332.Oct 4 2022, 7:03 PM

atul requested review of this revision.Oct 4 2022, 7:03 PM

tomek accepted this revision.Oct 5 2022, 2:01 AM

tomek added inline comments.

lib/utils/message-ops-utils.js
38	What this prop means and why it has the same value for video and its thumbnail?

This revision is now accepted and ready to land.Oct 5 2022, 2:01 AM

atul added inline comments.Oct 5 2022, 8:02 AM

lib/utils/message-ops-utils.js
38	It's a prop included for local media within media messages in redux. It is, however, redundant to include for both the "primary media" and "thumbnail" so I'll remove it from here before landing