Paths

Table of Contentst

[landing] implemented investor page boilerplate
ClosedPublic
Actions

Authored by ginsu on Oct 5 2022, 7:31 AM.

Details

Reviewers

atul
rohan
• abosh
ashoat

Commits

rCOMM3ac73f5ad31b: [landing] implemented investor page boilerplate

Summary

Will not land until all diffs in the stack are accepted

Boilerplate includes: Adding Investor page to Footer, creating Investor page with title and subtitle

Next diffs:

Implement Investor Card component
Populate Investor Cards with data

Linear Task: ENG-1953
Figma: Investor Page

Test Plan

Please view the screenshot to see the boilerplate UI of the investor page:

Screen Shot 2022-10-06 at 1.16.28 PM.png (2×3 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 5 2022, 7:31 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 5 2022, 7:31 AM

ginsu edited the summary of this revision. (Show Details)Oct 5 2022, 7:35 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan, • abosh.

ginsu attached a referenced file: F191590: Screen Shot 2022-10-05 at 10.26.33 AM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added inline comments.Oct 5 2022, 7:38 AM

landing/investors.css
1 ↗	(On Diff #17358)	Used the Team page styles as inspiration
landing/investors.react.js
1 ↗	(On Diff #17358)	Used the Team page as inspiration for boilerplate

Harbormaster completed remote builds in B12630: Diff 17358.Oct 5 2022, 7:42 AM

ginsu requested review of this revision.Oct 5 2022, 7:42 AM

Looks good to me, adding @ashoat as blocking since there's public facing copy.

landing/investors.react.js
15–16 ↗	(On Diff #17358)	Probably just missing some context here, but guessing the copy was signed off on by @ashoat?

rohan accepted this revision.Oct 5 2022, 12:46 PM

ashoat added inline comments.Oct 6 2022, 6:01 AM

landing/investors.react.js
15–16 ↗	(On Diff #17358)	Ahh, I may have implicitly accepted this copy in ENG-1952... but I actually would like to change it. How about: Comm is proud to count over 80 inviduals & organizations from our community as investors.

Requesting changes for another cycle of review, curious for @ginsu's and @atul's take on the new proposed copy

This revision now requires changes to proceed.Oct 6 2022, 6:02 AM

Yea I do like that a lot more in terms of engagement and delivery

Comm is proud to count over 80 inviduals & organizations from our community as investors.

Looks good

Note minor typo (individuals vs inviduals) before copy/pasting in

updated subtitle with ashoats feedback

Harbormaster failed remote builds in B12653: Diff 17387!Oct 6 2022, 10:16 AM

ginsu edited the test plan for this revision. (Show Details)Oct 6 2022, 10:17 AM

ginsu attached a referenced file: F192796: Screen Shot 2022-10-06 at 1.16.28 PM.png. (Show Details)

Noticed the keyserver build is down because of a temporary network issue with MariaDB release, will rebuild in a few hours

Harbormaster completed remote builds in B12653: Diff 17387.Oct 6 2022, 11:45 AM

Please address comments before landing

landing/investors.react.js
15 ↗	(On Diff #17387)	What's the point of this curly brace? Can we remove it?
16 ↗	(On Diff #17387)	Please keep every line to a max of 80 columns

This revision is now accepted and ready to land.Oct 6 2022, 1:50 PM

ginsu added inline comments.Oct 7 2022, 6:40 AM

landing/investors.react.js
15 ↗	(On Diff #17387)	& seems to be a special character, and my code editor was marking it as red. Everything seemed to still work w/o curly braces, but I thought it would be safer to include them. If we don't want them included though, happy to get rid of them
16 ↗	(On Diff #17387)	gotcha, will do that

ashoat added inline comments.Oct 7 2022, 6:43 AM

landing/investors.react.js
15 ↗	(On Diff #17387)	I think you can use `&`. Separately, curious what happens if you remove the curlies but keep the quotes? I think it's reasonable to keep the curlies if the quotes by themselves don't work, and you prefer the curlies to the `&` approach. But either way please reduce the line length to 80 columns