[landing] added social links to investor cards
ClosedPublic
Actions

Authored by ginsu on Oct 20 2022, 1:03 PM.

Details

Reviewers

atul
rohan
ashoat

Commits

rCOMM9f6862e0070d: [landing] added social links to investor cards

Summary

added social links to investor cards. For the design, I went with atul's idea to have the social icons justified to the left. I also went with the white hover tint because after a second thought, I felt the colors seemed a bit too "loud" especially since everything is black/white. This diff also adds Ranjan Pradeep to the investor directory.

Linear Task: ENG-1953
Figma: Investor Page

Depends on D5390

Test Plan

Please watch the demo video to see how the investor page looks/performs with the new social icons:

After feedback the investor profile cards now have a globe icon instead of the external link icon; demo runs exactly the same minus that one change

Investor Profile cards with globe icon:

Screen Shot 2022-10-21 at 4.31.58 PM.png (2×3 px, 2 MB)

Demo:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 20 2022, 1:03 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 20 2022, 1:03 PM

Harbormaster completed remote builds in B12949: Diff 17753.Oct 20 2022, 1:12 PM

ginsu requested review of this revision.Oct 20 2022, 1:12 PM

ginsu edited the summary of this revision. (Show Details)Oct 20 2022, 1:18 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan.

ginsu added a parent revision: D5390: [landing] populated investor page with investor data.

ginsu attached a referenced file: F205018: Screen Recording 2022-10-20 at 4.13.21 PM.mov. (Show Details)

Looks really good!

Looks close! Couple of comments to be addressed inline

landing/investor-data.js
28 ↗	(On Diff #17753)	Can we remove the `in/` here and leave just the usernames? We can add the `in/` back in `investor-profile.react.js`
landing/investor-profile.react.js
61 ↗	(On Diff #17753)	Let's memoize this using `React.useCallback(...)`
63 ↗	(On Diff #17753)	Can we use a globe icon here instead of external link?
75 ↗	(On Diff #17753)	Let's memoize this using `React.useCallback(...)`
89 ↗	(On Diff #17753)	Let's memoize this using `React.useCallback(...)`

This revision now requires changes to proceed.Oct 21 2022, 1:09 PM

ginsu added inline comments.Oct 21 2022, 1:16 PM

landing/investor-data.js
28 ↗	(On Diff #17753)	I don't think so unfortunately, some Investors link their company page, and LinkedIn makes company pages have the route `company/` (check slow ventures below)