[landing] implemented investor profile modal UI design
ClosedPublic
Actions

Authored by ginsu on Oct 19 2022, 10:52 AM.

Details

Reviewers

atul
rohan

Commits

rCOMM59015c9e892c: [landing] implemented investor profile modal UI design

Summary

Will not land until all diffs in stack have been accepted

implemented investor profile modal UI design. This diff just handles the jsx and styling of the modal, a seperate diff will be put up shortly to handle the actual population of data.

Linear Task: ENG-1953
Figma: Investor Page

Depends on D5334 and D5333

Test Plan

Please watch the demo videos to see what the modals would look like, and how they respond to different screen sizes:

Small description case:

Large description case:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 19 2022, 10:52 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 19 2022, 10:52 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 19 2022, 10:55 AM

Harbormaster failed remote builds in B12869: Diff 17660!

ginsu edited the summary of this revision. (Show Details)Oct 19 2022, 10:56 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan.

fixed classnames dependency

ginsu attached a referenced file: F203193: Screen Recording 2022-10-19 at 1.46.46 PM.mov. (Show Details)Oct 19 2022, 10:57 AM

ginsu edited the summary of this revision. (Show Details)Oct 19 2022, 11:01 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added a parent revision: D5334: [landing] introduced modal boilerplate.

ginsu attached a referenced file: F203228: Screen Recording 2022-10-19 at 1.45.36 PM.mov. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D5333: [landing] made investor profile cards mobile friendly.

Harbormaster completed remote builds in B12870: Diff 17661.Oct 19 2022, 11:07 AM

ginsu requested review of this revision.Oct 19 2022, 11:07 AM

ginsu added a child revision: D5390: [landing] populated investor page with investor data.Oct 19 2022, 11:24 AM

Accepting with couple of questions inline

landing/investor-profile.css
50 ↗	(On Diff #17661)	What happens if we don't explicitly set `cursor: default`?
53 ↗	(On Diff #17661)	Since this is a constant can we avoid using `calc()` and just have something like: max-width: min(691.2px, 90vw); or probably max-width: min(692px, 90vw); to avoid fractional pixel?
59 ↗	(On Diff #17661)	Do we need to explicitly set `height` to `auto` here? (even if not explicitly needed, feel free to leave in if you prefer)
70 ↗	(On Diff #17661)	Same as question about `height` in `descriptionModal`:
landing/investor-profile.react.js
24 ↗	(On Diff #17661)	If I'm understanding correctly, could this be named something like `isModalActive`?