Page MenuHomePhabricator
Differential D5323

[web] Use Button in join chat button
ClosedPublic
Actions

Authored by michal on Oct 10 2022, 2:56 AM.
Tags
None
Referenced Files
F1778147: D5323.id17728.diff
Fri, May 17, 9:38 AM
Unknown Object (File)
Sat, May 4, 2:58 AM
Unknown Object (File)
Sat, May 4, 2:58 AM
Unknown Object (File)
Sat, May 4, 2:58 AM
Unknown Object (File)
Sat, May 4, 2:57 AM
Unknown Object (File)
Sat, May 4, 2:38 AM
Unknown Object (File)
Sat, May 4, 2:05 AM
Unknown Object (File)
Apr 10 2024, 2:19 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
• abosh
ginsu
Commits
rCOMM9b70699e472d: [web] Use Button in join chat button
Summary

Part of ENG-843
Uses Button in join chat button instead of a plain <button>.

Test Plan

Check if the button looks the same and works correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Oct 10 2022, 2:56 AM
Herald added a subscriber: ashoat. · View Herald TranscriptOct 10 2022, 2:56 AM
michal added a parent revision: D5322: [web] Use Button for text buttons.Oct 10 2022, 2:57 AM
michal edited the summary of this revision. (Show Details)Oct 10 2022, 3:00 AM
michal added a child revision: D5324: [web] Use Button for relationship buttons.
Harbormaster completed remote builds in B12685: Diff 17435.Oct 10 2022, 3:07 AM
michal requested review of this revision.Oct 10 2022, 3:07 AM
ashoat added a reviewer: ginsu.Oct 10 2022, 8:40 AM
atul accepted this revision.Oct 10 2022, 10:06 AM

Check if the button looks the same.

Should probably include something in the Test Plan about trying to join a thread and ensuring things continue to work as expected since you modified onClickJoin()

This revision is now accepted and ready to land.Oct 10 2022, 10:06 AM
michal edited the test plan for this revision. (Show Details)Oct 11 2022, 2:50 AM
tomek accepted this revision.Oct 11 2022, 4:02 AM
tomek added inline comments.
web/chat/chat-input-bar.react.js
190 ↗(On Diff #17435)

Should we remove this class from css file?

michal updated this revision to Diff 17487.Oct 11 2022, 6:03 AM

Cleaned up css.

michal requested review of this revision.Oct 11 2022, 6:04 AM
Harbormaster completed remote builds in B12726: Diff 17487.Oct 11 2022, 6:13 AM
ginsu accepted this revision.Oct 11 2022, 7:09 AM

nice looks good!

This revision is now accepted and ready to land.Oct 11 2022, 7:09 AM
michal added 1 blocking reviewer(s): tomek.Oct 11 2022, 7:20 AM
This revision now requires review to proceed.Oct 11 2022, 7:20 AM
atul accepted this revision.Oct 11 2022, 7:32 AM

Looks good thanks for updating the Test Plan

tomek accepted this revision.Oct 12 2022, 6:02 AM
This revision is now accepted and ready to land.Oct 12 2022, 6:02 AM
michal updated this revision to Diff 17708.Oct 20 2022, 6:58 AM

Rebase

Harbormaster completed remote builds in B12917: Diff 17708.Oct 20 2022, 7:30 AM
Closed by commit rCOMM9b70699e472d: [web] Use Button in join chat button (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyOct 20 2022, 8:55 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM9b70699e472d: [web] Use Button in join chat button.

Revision Contents
Changeset List

PathSize
web/
chat/
20 lines
12 lines

Diff 17728

View Options

web/chat/chat-input-bar.css

Loading...
View Options

web/chat/chat-input-bar.react.js

Loading...