Differential D5459

[native] moved tooltip toolbar to the bottom of the chat window
AbandonedPublic
Actions

Authored by ginsu on Oct 21 2022, 7:32 PM.

Tags

None

Referenced Files

	F205879: Screen Recording 2022-10-21 at 3.29.18 PM.mov
	Oct 21 2022, 7:45 PM

Subscribers

Details

Reviewers

atul
rohan
ashoat

Summary

moved the tooltip toolbar to the bottom of the chat window. Will be polishing the animation/UI in upcoming diffs

Depends on D5452
Linear Task: ENG-2037

Test Plan

Please watch the demo to see how the tooltip toolbar now looks visually

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 21 2022, 7:32 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 21 2022, 7:32 PM

Harbormaster completed remote builds in B12977: Diff 17827.Oct 21 2022, 7:43 PM

ginsu requested review of this revision.Oct 21 2022, 7:43 PM

ginsu edited the summary of this revision. (Show Details)Oct 21 2022, 7:45 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan.

ginsu added a parent revision: D5452: [native] removed tooltip location logic.

ginsu attached a referenced file: F205879: Screen Recording 2022-10-21 at 3.29.18 PM.mov. (Show Details)

ginsu added a child revision: D5460: [native] changed tooltip toolbar color from light to dark.Oct 21 2022, 8:13 PM

Have you thought about how this impacts the other Tooltips?

This revision now requires changes to proceed.Oct 21 2022, 9:09 PM

rebase

ginsu planned changes to this revision.Oct 24 2022, 3:36 PM

Harbormaster completed remote builds in B12999: Diff 17858.Oct 24 2022, 3:44 PM

abandoning diff because D5468 now handles this logic

Revision Contents
Changeset List

Path

Size

native/

navigation/

tooltip.react.js

9 lines

Diff 17858

native/navigation/tooltip.react.js

Loading...