Page MenuHomePhabricator

[native] changed tooltip toolbar color from light to dark
ClosedPublic

Authored by ginsu on Oct 21 2022, 1:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 10:34 AM
Unknown Object (File)
Fri, Oct 25, 10:43 PM
Unknown Object (File)
Fri, Oct 25, 10:43 PM
Unknown Object (File)
Fri, Oct 25, 10:43 PM
Unknown Object (File)
Fri, Oct 25, 10:43 PM
Unknown Object (File)
Fri, Oct 25, 10:43 PM
Unknown Object (File)
Fri, Oct 25, 10:43 PM
Unknown Object (File)
Fri, Oct 25, 10:43 PM

Details

Summary

changed color of all tooltips from light to dark, as discussed in this Linear comment Will touch up animation, and add the more button for the fixed tooltips in a seperate diff


Depends on D5451
Linear Task: ENG-2037
Design: Figma

Test Plan

Please view the video demo to see how all the tooltips now look in the new theme:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Oct 21 2022, 1:21 PM

Looks great

native/navigation/tooltip.react.js
457 ↗(On Diff #17828)

I'd personally prefer if we used hex for colors throughout

471 ↗(On Diff #17828)

Can we capitalize the fs here?

This revision is now accepted and ready to land.Oct 21 2022, 2:17 PM

Can you share screenshots of how this looks for all of the other tooltips? High-level feedback – whenever updating the Tooltip code, please make sure you consider all codepaths that will impact... we should see other codepaths referenced in the Test Plan and in screenshots

Can you share screenshots of how this looks for all of the other tooltips? High-level feedback – whenever updating the Tooltip code, please make sure you consider all codepaths that will impact... we should see other codepaths referenced in the Test Plan and in screenshots

Gotcha, I will make sure to be very explicit about this in the test cases in the future

ashoat requested changes to this revision.Oct 24 2022, 10:59 AM

Missing tooltips

This revision now requires changes to proceed.Oct 24 2022, 10:59 AM
ginsu edited the test plan for this revision. (Show Details)

made ALL tooltips dark

ginsu edited the test plan for this revision. (Show Details)
ginsu added 1 blocking reviewer(s): atul.
ginsu edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Oct 26 2022, 11:14 AM