Page MenuHomePhabricator
Differential D5374

[native] added icons to tooltip item component
ClosedPublic
Actions

Authored by ginsu on Oct 15 2022, 11:55 AM.
Tags
None
Referenced Files
F2105307: D5374.id17627.diff
Tue, Jun 25, 6:55 AM
F2102521: D5374.id.diff
Tue, Jun 25, 12:46 AM
Unknown Object (File)
Sat, Jun 22, 4:15 AM
Unknown Object (File)
Tue, Jun 18, 5:09 PM
Unknown Object (File)
Mon, Jun 17, 6:04 AM
Unknown Object (File)
Mon, Jun 17, 6:04 AM
Unknown Object (File)
Thu, Jun 13, 6:07 AM
Unknown Object (File)
Wed, Jun 12, 5:54 AM
View All 89 Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
rohan
• abosh
Commits
rCOMMe7cb15a7708f: [native] added icons to tooltip item component
Summary

added icons to the TooltipItem component. The five options of the TooltipItem are copy, reply, report, creae sidebar and open sidebar. Once we have the icons, we will convert the tooltip into the toolbar.

Linear Task: ENG-1541

Test Plan

Please review the screenshots to see the before and after for the changes i made:

Before:

Screen Shot 2022-10-14 at 2.09.30 PM.png (1×1 px, 642 KB)

After:
Create Thread Case:

Screen Shot 2022-10-15 at 2.51.27 PM.png (1×1 px, 620 KB)

Open Thread Case:

Screen Shot 2022-10-15 at 2.51.11 PM.png (1×1 px, 629 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 15 2022, 11:55 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 15 2022, 11:55 AM
ginsu edited the test plan for this revision. (Show Details)Oct 15 2022, 11:59 AM
ginsu attached a referenced file: F201039: Screen Shot 2022-10-15 at 2.51.27 PM.png. (Show Details)
ginsu attached a referenced file: F201037: Screen Shot 2022-10-14 at 2.09.30 PM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)Oct 15 2022, 12:01 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F201042: Screen Shot 2022-10-15 at 2.51.11 PM.png. (Show Details)
ginsu added reviewers: atul, rohan, • abosh.
Harbormaster completed remote builds in B12816: Diff 17600.Oct 15 2022, 12:05 PM
ginsu requested review of this revision.Oct 15 2022, 12:05 PM
rohan accepted this revision.Oct 15 2022, 1:41 PM

Pulled this locally and it all looks good to me, nice!

atul accepted this revision.Oct 15 2022, 1:45 PM

Looks good!

This revision is now accepted and ready to land.Oct 15 2022, 1:45 PM
ginsu added a child revision: D5381: [native] switched fixed tooltip component from a vertical layout to horizontal.Oct 17 2022, 8:25 AM
Closed by commit rCOMMe7cb15a7708f: [native] added icons to tooltip item component (authored by ginsu). · Explain WhyOct 17 2022, 1:53 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe7cb15a7708f: [native] added icons to tooltip item component.
ashoat added a comment.EditedFeb 2 2023, 4:43 PM

We really shouldn't have added application-specific code here... it violates separation of concerns. This should've gone on the TooltipSpec

ginsu added a comment.Feb 2 2023, 8:10 PM

We really shouldn't have added application-specific code here... it violates separation of concerns. This should've gone on the TooltipSpec

Yea looking at this again, you are definitely right. I created a task to address this

Revision Contents
Changeset List

PathSize
native/
navigation/
32 lines

Diff 17627

View Options

native/navigation/tooltip.react.js

Loading...