Paths

Table of Contentst

-
native/navigation/
-
navigation/
-
tooltip.react.js

[native] added icons to tooltip item component
ClosedPublic
Actions

Authored by ginsu on Oct 15 2022, 11:55 AM.

Details

Reviewers

atul
rohan
• abosh

Commits

rCOMMe7cb15a7708f: [native] added icons to tooltip item component

Summary

added icons to the TooltipItem component. The five options of the TooltipItem are copy, reply, report, creae sidebar and open sidebar. Once we have the icons, we will convert the tooltip into the toolbar.

Linear Task: ENG-1541

Test Plan

Please review the screenshots to see the before and after for the changes i made:

Before:

Screen Shot 2022-10-14 at 2.09.30 PM.png (1×1 px, 642 KB)

After:
Create Thread Case:

Screen Shot 2022-10-15 at 2.51.27 PM.png (1×1 px, 620 KB)

Open Thread Case:

Screen Shot 2022-10-15 at 2.51.11 PM.png (1×1 px, 629 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 15 2022, 11:55 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 15 2022, 11:55 AM

ginsu edited the test plan for this revision. (Show Details)Oct 15 2022, 11:59 AM

ginsu attached a referenced file: F201039: Screen Shot 2022-10-15 at 2.51.27 PM.png. (Show Details)

ginsu attached a referenced file: F201037: Screen Shot 2022-10-14 at 2.09.30 PM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)Oct 15 2022, 12:01 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F201042: Screen Shot 2022-10-15 at 2.51.11 PM.png. (Show Details)

ginsu added reviewers: atul, rohan, • abosh.

Harbormaster completed remote builds in B12816: Diff 17600.Oct 15 2022, 12:05 PM

ginsu requested review of this revision.Oct 15 2022, 12:05 PM

Pulled this locally and it all looks good to me, nice!

Looks good!

This revision is now accepted and ready to land.Oct 15 2022, 1:45 PM

ginsu added a child revision: D5381: [native] switched fixed tooltip component from a vertical layout to horizontal.Oct 17 2022, 8:25 AM

Closed by commit rCOMMe7cb15a7708f: [native] added icons to tooltip item component (authored by ginsu). · Explain WhyOct 17 2022, 1:53 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMe7cb15a7708f: [native] added icons to tooltip item component.

We really shouldn't have added application-specific code here... it violates separation of concerns. This should've gone on the TooltipSpec

We really shouldn't have added application-specific code here... it violates separation of concerns. This should've gone on the TooltipSpec

Yea looking at this again, you are definitely right. I created a task to address this

Revision Contents
Changeset List

Path

Size

native/

navigation/

tooltip.react.js

32 lines

Diff 17627

View Options

native/navigation/tooltip.react.js

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

[native] added icons to tooltip item componentClosedPublicActions