[CI] Remove "Clean up provisioning profile" step from iOS workflows
ClosedPublic
Actions

Authored by atul on Nov 7 2022, 5:20 PM.

Details

Reviewers

tomek
varun
marcin
rohan
ginsu
ashoat

Commits

rCOMMe07448322ed3: [CI] Remove "Clean up provisioning profile" step from iOS workflows

Summary

Removes the "Clean up provisioning profile" step from GH Actions iOS workflows since it's unnecessary.

We're no longer passing in any provisioning profiles, so there's nothing to delete

Test Plan

Made sure it was fine to remove this step in a fork of repo

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 7 2022, 5:20 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 7 2022, 5:20 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2022, 5:26 PM

Harbormaster failed remote builds in B13242: Diff 18169!

atul requested review of this revision.Nov 7 2022, 7:21 PM

Harbormaster completed remote builds in B13242: Diff 18169.Nov 7 2022, 8:28 PM

Is there any downside to keeping this step?

In D5552#164571, @ashoat wrote:

Is there any downside to keeping this step?

Not really, just simplifying the workflow to keep things a bit more readable.

We'll need to cut the rm ~/Library/MobileDevice/Provisioning\ Profiles/build_pp.mobileprovision regardless since we're no longer passing in provisioning profiles, but we can keep the security delete-keychain $RUNNER_TEMP/app-signing.keychain-db line in to make sure that we're "cleaning up" after each build.

Defer to you

This revision is now accepted and ready to land.Nov 8 2022, 6:31 AM

update cleanup step to only handle certificates

Harbormaster failed remote builds in B13257: Diff 18190!Nov 8 2022, 6:39 AM

In D5552#164641, @ashoat wrote:

Defer to you

Updated to handle just certificates since we're not going to be dealing with provisioning profiles anyways. This probably makes things more "portable" if we one day go with self-hosted macOS runners (maybe 10-15min staff releases instead of 1-1.5hr)

atul retitled this revision from [CI] Remove "Clean up keychain and provisioning profile" step from iOS workflows to Remove "Clean up provisioning profile" step from iOS workflows.Nov 8 2022, 6:45 AM

atul edited the summary of this revision. (Show Details)

atul retitled this revision from Remove "Clean up provisioning profile" step from iOS workflows to [CI] Remove "Clean up provisioning profile" step from iOS workflows.

This revision was landed with ongoing or failed builds.Nov 8 2022, 6:47 AM

Closed by commit rCOMMe07448322ed3: [CI] Remove "Clean up provisioning profile" step from iOS workflows (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMe07448322ed3: [CI] Remove "Clean up provisioning profile" step from iOS workflows.

Harbormaster completed remote builds in B13257: Diff 18190.Nov 8 2022, 6:56 AM