Page MenuHomePhabricator
Differential D5573

[services][identity] update get_pake_registration method to use helper
ClosedPublic
Actions

Authored by varun on Nov 8 2022, 3:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 12:31 AM
Unknown Object (File)
Mon, Nov 4, 12:25 AM
Unknown Object (File)
Mon, Nov 4, 12:23 AM
Unknown Object (File)
Mon, Nov 4, 12:18 AM
Unknown Object (File)
Mon, Oct 28, 4:31 PM
Unknown Object (File)
Fri, Oct 25, 5:18 PM
Unknown Object (File)
Fri, Oct 25, 5:18 PM
Unknown Object (File)
Fri, Oct 25, 5:17 PM
View All 69 Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
tomek
bartek
• jon
Commits
rCOMM14257cb309a6: [services][identity] update get_pake_registration method to use helper
Summary

previously introduced a helper function that gets an item from the users table in DDB with the provided user_id. we should use that helper function here.

Test Plan

built and ran the identity service successfully and called the login RPC to check that it works as expected

Diff Detail

Repository
rCOMM Comm
Branch
get_user_public_key (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Nov 8 2022, 3:01 PM
Herald added a reviewer: • jon. · View Herald TranscriptNov 8 2022, 3:01 PM
Herald added subscribers: • abosh, atul, ashoat. · View Herald Transcript
varun added a parent revision: D5570: [services][identity] implement get_user_public_key service method.Nov 8 2022, 3:01 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2022, 3:10 PM
Harbormaster failed remote builds in B13297: Diff 18242!
Harbormaster completed remote builds in B13297: Diff 18242.Nov 8 2022, 3:24 PM
varun requested review of this revision.Nov 8 2022, 3:24 PM
• jon accepted this revision.Nov 9 2022, 11:15 AM
varun added a child revision: D5585: [keyserver] add gRPC client module to keyserver.Nov 9 2022, 12:01 PM
bartek accepted this revision.Nov 9 2022, 1:16 PM
tomek accepted this revision.Nov 10 2022, 5:40 AM
This revision is now accepted and ready to land.Nov 10 2022, 5:40 AM
Closed by commit rCOMM14257cb309a6: [services][identity] update get_pake_registration method to use helper (authored by varun). · Explain WhyNov 10 2022, 12:49 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM14257cb309a6: [services][identity] update get_pake_registration method to use helper.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
14 lines

Diff 18242

View Options

services/identity/src/database.rs

Loading...