[native] fix `getDeviceID` return type
ClosedPublic
Actions

Authored by kamil on Nov 9 2022, 10:46 AM.

Details

Reviewers

marcin
inka
tomek

Commits

rCOMM24dec60ecf51: [native] fix `getDeviceID` return type

Summary

context: eng-2184
Fix the typo in type definition.

Test Plan

Build app
Check if deviceID value is properly returned

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 9 2022, 10:46 AM

kamil held this revision as a draft.

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptNov 9 2022, 10:46 AM

kamil edited the summary of this revision. (Show Details)Nov 9 2022, 10:48 AM

kamil edited the test plan for this revision. (Show Details)

kamil added a reviewer: inka.

Harbormaster completed remote builds in B13305: Diff 18253.Nov 9 2022, 10:59 AM

kamil published this revision for review.Nov 9 2022, 1:29 PM

inka accepted this revision.Nov 10 2022, 10:08 AM

This revision is now accepted and ready to land.Nov 10 2022, 10:08 AM

kamil added a reviewer: tomek.Nov 10 2022, 10:09 AM

This revision now requires review to proceed.Nov 10 2022, 10:09 AM

marcin accepted this revision.Nov 14 2022, 10:09 AM

tomek accepted this revision.Nov 14 2022, 6:27 PM

This revision is now accepted and ready to land.Nov 14 2022, 6:27 PM

Closed by commit rCOMM24dec60ecf51: [native] fix `getDeviceID` return type. · Explain WhyNov 15 2022, 2:20 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM24dec60ecf51: [native] fix `getDeviceID` return type.

Revision Contents
Changeset List

Path

Size

native/

schema/

CommCoreModuleSchema.js

2 lines

Diff 18429

View Options

native/schema/CommCoreModuleSchema.js

[native] fix `getDeviceID` return typeClosedPublicActions