Paths

Table of Contentst

[native] Fix appearance of `ThreadAncestors` in light mode
ClosedPublic
Actions

Authored by atul on Nov 10 2022, 5:47 PM.

Details

Reviewers

tomek
marcin
ginsu
rohan
• abosh
varun
ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMabab87c2c52c: [native] Fix appearance of `ThreadAncestors` in light mode

Summary

Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

Basically use a color from colors.js for the rightArrow instead of hardcoding "white".

Test Plan

Before:

After:

Things look as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 10 2022, 5:47 PM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 10 2022, 5:47 PM

atul edited the test plan for this revision. (Show Details)Nov 10 2022, 5:48 PM

Harbormaster completed remote builds in B13392: Diff 18367.Nov 10 2022, 6:01 PM

atul requested review of this revision.Nov 10 2022, 6:01 PM

ginsu accepted this revision.Nov 11 2022, 8:36 AM

This revision is now accepted and ready to land.Nov 11 2022, 8:36 AM

atul added a reviewer: Restricted Owners Package.Nov 11 2022, 8:53 AM

This revision now requires review to proceed.Nov 11 2022, 8:53 AM

ashoat accepted this revision.Nov 11 2022, 1:02 PM

This revision is now accepted and ready to land.Nov 11 2022, 1:02 PM

Closed by commit rCOMMabab87c2c52c: [native] Fix appearance of `ThreadAncestors` in light mode (authored by atul). · Explain WhyNov 11 2022, 1:09 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMabab87c2c52c: [native] Fix appearance of `ThreadAncestors` in light mode.

Revision Contents
Changeset List

Path

Size

native/

components/

thread-ancestors.react.js

32 lines

Diff 18385

View Options

native/components/thread-ancestors.react.js

[native] Fix appearance of `ThreadAncestors` in light modeClosedPublicActions