[native] Fix appearance of `Calendar` in light mode
ClosedPublic
Actions

Authored by atul on Nov 10 2022, 7:18 PM.

Details

Reviewers

tomek
marcin
ginsu
rohan
• abosh
varun
ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMeaa421707f81: [native] Fix appearance of `Calendar` in light mode

Summary

Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

Test Plan

Before:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-10 at 22.29.39.png (2×1 px, 220 KB)

After:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-10 at 22.29.00.png (2×1 px, 222 KB)

Things looks as expected (on dark mode as well).

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 10 2022, 7:18 PM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 10 2022, 7:18 PM

Harbormaster completed remote builds in B13395: Diff 18370.Nov 10 2022, 7:28 PM

atul requested review of this revision.Nov 10 2022, 7:28 PM

atul edited the test plan for this revision. (Show Details)Nov 10 2022, 7:29 PM

sweet i like the color contrast between foreground and background

This revision is now accepted and ready to land.Nov 11 2022, 8:27 AM

atul added a reviewer: Restricted Owners Package.Nov 11 2022, 8:52 AM

This revision now requires review to proceed.Nov 11 2022, 8:52 AM

ashoat accepted this revision.Nov 11 2022, 1:02 PM

This revision is now accepted and ready to land.Nov 11 2022, 1:02 PM

Closed by commit rCOMMeaa421707f81: [native] Fix appearance of `Calendar` in light mode (authored by atul). · Explain WhyNov 11 2022, 1:09 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMeaa421707f81: [native] Fix appearance of `Calendar` in light mode.

Revision Contents
Changeset List

Path

Size

native/

calendar/

calendar.react.js

2 lines

section-footer.react.js

2 lines

Diff 18370

View Options

native/calendar/calendar.react.js